674207 - TM: Assertion failure: isNumber(), at jsvalue.h:604

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Christian Holler (:decoder)]

The following test asserts on mozilla-inbound revision 8160165dfcb4:

unescape(it);

Bisect shows:

Changeset 71368:d2250fc608cc: bad
The first bad revision is:
changeset:   71368:d2250fc608cc
user:        Jeff Walden
date:        Fri Apr 01 15:24:21 2011 -0700
summary:     Bug 646129 - [[DefaultValue]] on Date objects is wrong when called with no hint.  r=luke


Although this issue was found using a mutation of the "prop_iter_trace" test for coverage increase in 669864, I don't see a direct connection there. If I'm wrong there and this function is related, let me know.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

This is fallout from a minor adjustment to how the convert hook works -- added an assertion that makes the problem clearer.  I also went and updated JSClass.convert and JS_ConvertStub docs on MDN for this adjustment, while it was on the brain.

Comment 2

[Jeff Walden [:Waldo]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/a774533fbbf1

<3 being able to push and not have to watch the tree.  :-)  (This was tryservered, in my defense, if this blows up in my face for some reason.)

Comment 3

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/a774533fbbf1

Comment 4

[Christian Holler (:decoder)]

Automatically extracted testcase for this bug was committed:

https://hg.mozilla.org/mozilla-central/rev/efaf8960a929