Closed
Bug 674229
Opened 14 years ago
Closed 14 years ago
Repeat bubbles in Web Console are too close to the Source Link
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 8
People
(Reporter: rcampbell, Assigned: rcampbell)
Details
Attachments
(4 files, 2 obsolete files)
The repeat bubbles in the web console are running into the source link area in the web console. See attached screenshot.
Assignee | ||
Comment 1•14 years ago
|
||
added pack="end" to the repeated nodes to ensure adequate spacing is retained.
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
Attachment #548662 -
Flags: review?(ddahl)
Attachment #548662 -
Flags: review?(dao)
Comment 2•14 years ago
|
||
width:1em on the label is causing this problem, isn't it? Why is this applied in the first place?
Comment 3•14 years ago
|
||
(In reply to comment #2)
> width:1em on the label is causing this problem, isn't it? Why is this
> applied in the first place?
In the CSS, I removed the width from the node and from the 'webconsole-location' node, and got this result:
http://img840.imageshack.us/img840/4610/selection028g.png
Comment 4•14 years ago
|
||
Comment on attachment 548662 [details] [diff] [review]
Packed
So if I understand it correctly, comment 3 confirms that width:1em isn't needed and removing it fixes this bug.
Attachment #548662 -
Flags: review?(dao) → review-
Assignee | ||
Comment 5•14 years ago
|
||
the spacing looks a little tight around that source link, but at least it's not bleeding into it.
No idea why there's a 1em width on this, I don't remember.
Assignee | ||
Comment 6•14 years ago
|
||
removed the pack attribute and excised the widths from both the source link and repeat bubbles. Result fits at least, but the bubbles are right aligned with the left edge of the source.
Attachment #548662 -
Attachment is obsolete: true
Attachment #548662 -
Flags: review?(ddahl)
Attachment #548834 -
Flags: review?(ddahl)
Attachment #548834 -
Flags: review?(dao)
Assignee | ||
Comment 7•14 years ago
|
||
Comment 8•14 years ago
|
||
Comment on attachment 548834 [details] [diff] [review]
unpacked
(In reply to comment #6)
> Result fits at least, but the bubbles are right aligned
> with the left edge of the source.
That's because you removed width:10em from .webconsole-location, which seems wrong... It's probably going to prevent the location from being cropped too.
Attachment #548834 -
Flags: review?(dao) → review-
Comment 9•14 years ago
|
||
(In reply to comment #8)
> That's because you removed width:10em from .webconsole-location, which seems
> wrong... It's probably going to prevent the location from being cropped too.
What would be the ideal solution here? just remove the 1em width on the repeat bubble nodes? I was tinkering with it in DOMInspector and I thought the overlap was still there with just the 'width:1em' removed.
Comment 10•14 years ago
|
||
(In reply to comment #9)
> I was tinkering with it in DOMInspector and I thought
> the overlap was still there with just the 'width:1em' removed.
That's not what I see.
Also, do you know what change caused this problem? This seems to be a recent regression.
Assignee | ||
Comment 11•14 years ago
|
||
(In reply to comment #10)
> (In reply to comment #9)
> > I was tinkering with it in DOMInspector and I thought
> > the overlap was still there with just the 'width:1em' removed.
>
> That's not what I see.
>
> Also, do you know what change caused this problem? This seems to be a recent
> regression.
yeah, it's a regression from bug 662807. align="start" seems to have compressed the layout of these nodes.
I'll re-add the width to the .webconsole-location and resubmit with a screenshot.
Assignee | ||
Comment 12•14 years ago
|
||
this looks much better.
Assignee | ||
Comment 13•14 years ago
|
||
With the width of the source link readded, this looks much better. Thanks!
Attachment #548834 -
Attachment is obsolete: true
Attachment #548834 -
Flags: review?(ddahl)
Attachment #549078 -
Flags: review?(ddahl)
Attachment #549078 -
Flags: review?(dao)
Updated•14 years ago
|
Attachment #549078 -
Flags: review?(dao) → review+
Assignee | ||
Comment 14•14 years ago
|
||
Comment on attachment 549078 [details] [diff] [review]
[in-fx-team] unpacked, unwidthed
moving review to mihai to get this checked in.
Attachment #549078 -
Flags: review?(ddahl) → review?(mihai.sucan)
Updated•14 years ago
|
Attachment #549078 -
Flags: review+
Comment 15•14 years ago
|
||
Comment on attachment 549078 [details] [diff] [review]
[in-fx-team] unpacked, unwidthed
Good to go!
Attachment #549078 -
Flags: review?(mihai.sucan) → review+
Comment 16•14 years ago
|
||
(In reply to comment #14)
> Comment on attachment 549078 [details] [diff] [review] [diff] [details] [review]
> unpacked, unwidthed
>
> moving review to mihai to get this checked in.
FYI, I'm the owner of toolkit/themes/.
Assignee | ||
Comment 17•14 years ago
|
||
(In reply to comment #16)
> (In reply to comment #14)
> > Comment on attachment 549078 [details] [diff] [review] [diff] [details] [review] [diff] [details] [review]
> > unpacked, unwidthed
> >
> > moving review to mihai to get this checked in.
>
> FYI, I'm the owner of toolkit/themes/.
I know. I just wanted signoff from a devtools peer too.
Thanks for the reviews, all!
Assignee | ||
Updated•14 years ago
|
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Comment 18•14 years ago
|
||
Comment on attachment 549078 [details] [diff] [review]
[in-fx-team] unpacked, unwidthed
http://hg.mozilla.org/integration/fx-team/rev/e2e7b2275ade
Attachment #549078 -
Attachment description: unpacked, unwidthed → [in-fx-team] unpacked, unwidthed
Comment 19•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 8
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•