Last Comment Bug 674230 - Land qcms LUT support with Pref
: Land qcms LUT support with Pref
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: GFX: Color Management (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla8
Assigned To: Benoit Girard (:BenWa)
:
Mentors:
Depends on: CVE-2012-1960
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-26 08:18 PDT by Benoit Girard (:BenWa)
Modified: 2012-07-12 16:37 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Part 1: Merge from qcms github branch v4 (148.74 KB, patch)
2011-07-26 12:13 PDT, Benoit Girard (:BenWa)
no flags Details | Diff | Review
Part 2: Add gfx.color_management.force_v4 (2.89 KB, patch)
2011-07-26 12:14 PDT, Benoit Girard (:BenWa)
no flags Details | Diff | Review
Part 1: Merge from qcms github branch v4 (149.29 KB, patch)
2011-07-27 07:13 PDT, Benoit Girard (:BenWa)
jmuizelaar: review+
Details | Diff | Review
Part 2: Add gfx.color_management.force_v4 (2.95 KB, patch)
2011-07-27 07:14 PDT, Benoit Girard (:BenWa)
jmuizelaar: review+
Details | Diff | Review
Part 2: Add gfx.color_management.force_v4 + qcms pref inline (7.75 KB, patch)
2011-07-27 11:18 PDT, Benoit Girard (:BenWa)
no flags Details | Diff | Review
Follow up: Rename pref (2.12 KB, patch)
2011-07-27 13:10 PDT, Benoit Girard (:BenWa)
jmuizelaar: review+
Details | Diff | Review

Description Benoit Girard (:BenWa) 2011-07-26 08:18:09 PDT
The goal is to land new qcms ICC v4 features such as CLUT support on m-c with a preference to enable them.
Comment 1 Benoit Girard (:BenWa) 2011-07-26 12:13:50 PDT
Created attachment 548542 [details] [diff] [review]
Part 1: Merge from qcms github branch v4

https://github.com/jrmuizel/qcms/commits/v4
Comment 2 Benoit Girard (:BenWa) 2011-07-26 12:14:43 PDT
Created attachment 548543 [details] [diff] [review]
Part 2: Add gfx.color_management.force_v4

Feel free to nit pick about the name.

Waiting for tryserver results before flagging review.
Comment 3 Benoit Girard (:BenWa) 2011-07-27 07:13:11 PDT
Created attachment 548768 [details] [diff] [review]
Part 1: Merge from qcms github branch v4
Comment 4 Benoit Girard (:BenWa) 2011-07-27 07:14:47 PDT
Created attachment 548770 [details] [diff] [review]
Part 2: Add gfx.color_management.force_v4
Comment 5 Benoit Girard (:BenWa) 2011-07-27 07:16:00 PDT
Try run:
http://tbpl.mozilla.org/?tree=Try&pusher=b56girard@gmail.com&rev=661b4dd715a4
Comment 6 Jeff Muizelaar [:jrmuizel] 2011-07-27 10:39:23 PDT
Comment on attachment 548770 [details] [diff] [review]
Part 2: Add gfx.color_management.force_v4

I don't really see the point of CMVersionFourPrefName. The only thing I can think of is to keep all of the different prefs close together. However, I think documentation would serve this just as well.

I suggest just using the name directly. I'd also take a patch to inline all of the other names.
Comment 7 Benoit Girard (:BenWa) 2011-07-27 11:18:06 PDT
Created attachment 548841 [details] [diff] [review]
Part 2: Add gfx.color_management.force_v4 + qcms pref inline

Carrying forward r+
Comment 8 Benoit Girard (:BenWa) 2011-07-27 11:47:26 PDT
http://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=2148365fbb7c
Comment 9 Benoit Girard (:BenWa) 2011-07-27 13:10:21 PDT
Created attachment 548885 [details] [diff] [review]
Follow up: Rename pref
Comment 10 :Ehsan Akhgari (out sick) 2011-07-28 08:15:35 PDT
http://hg.mozilla.org/mozilla-central/rev/77305d830151
Comment 11 :Ehsan Akhgari (out sick) 2011-07-28 08:16:07 PDT
Also: http://hg.mozilla.org/mozilla-central/rev/86ff239e3948
Comment 12 :Ehsan Akhgari (out sick) 2011-07-28 08:18:24 PDT
Also: http://hg.mozilla.org/mozilla-central/rev/8d309b30299a
Comment 13 Benoit Girard (:BenWa) 2011-07-29 13:08:31 PDT
I just tested with the following profile: http://www.colorkeeper.com/?page_id=235

We get the un managed result without v4 and the perceptual with the v4 pref. I would of expected to get the TRC result however we are less strict with the profiles we reject now.

The profile in the package is very interesting. It shows very obviously what is being managed and what is not (i.e. the browser chrome).

Note You need to log in before you can comment on or make changes to this bug.