Closed Bug 674230 Opened 8 years ago Closed 8 years ago

Land qcms LUT support with Pref

Categories

(Core :: GFX: Color Management, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

Attachments

(3 files, 3 obsolete files)

The goal is to land new qcms ICC v4 features such as CLUT support on m-c with a preference to enable them.
Feel free to nit pick about the name.

Waiting for tryserver results before flagging review.
Attachment #548543 - Attachment is patch: true
Attachment #548768 - Flags: review?(jmuizelaar)
Attachment #548542 - Attachment is obsolete: true
Attachment #548543 - Attachment is obsolete: true
Attachment #548770 - Flags: review?(jmuizelaar)
Attachment #548768 - Flags: review?(jmuizelaar) → review+
Comment on attachment 548770 [details] [diff] [review]
Part 2: Add gfx.color_management.force_v4

I don't really see the point of CMVersionFourPrefName. The only thing I can think of is to keep all of the different prefs close together. However, I think documentation would serve this just as well.

I suggest just using the name directly. I'd also take a patch to inline all of the other names.
Attachment #548770 - Flags: review?(jmuizelaar) → review+
Carrying forward r+
Attachment #548770 - Attachment is obsolete: true
Attachment #548885 - Flags: review?(jmuizelaar)
Attachment #548885 - Flags: review?(jmuizelaar) → review+
http://hg.mozilla.org/mozilla-central/rev/77305d830151
Assignee: nobody → bgirard
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
I just tested with the following profile: http://www.colorkeeper.com/?page_id=235

We get the un managed result without v4 and the perceptual with the v4 pref. I would of expected to get the TRC result however we are less strict with the profiles we reject now.

The profile in the package is very interesting. It shows very obviously what is being managed and what is not (i.e. the browser chrome).
Depends on: 752254
No longer depends on: 752254
Depends on: CVE-2012-1960
I just stumbled across this feature when visiting http://cameratico.com/tools/web-browser-color-management-test/ and noticing the "v4" brokenness there in Firefox.  (though it works if I toggle this bug's pref & restart Firefox)

Does anyone recall why this feature was pref-controlled & preffed-off-by-default? i.e. was there some remaining work to be done before it could be enabled? Or was the feature known-to-be-permanently-problematic so we wanted to make it opt in? Or something else?
Flags: needinfo?(jmuizelaar)
Performance isn't great and there might be security problems.
Flags: needinfo?(jmuizelaar)
You need to log in before you can comment on or make changes to this bug.