Workaround event handler having the same original prototype node

RESOLVED FIXED in seamonkey2.17

Status

SeaMonkey
General
--
major
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Trunk
seamonkey2.17
Dependency tree / graph
Bug Flags:
in-testsuite -

SeaMonkey Tracking Flags

(seamonkey2.2 affected, seamonkey2.3 fixed, seamonkey2.4 fixed, seamonkey2.17 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 548488 [details] [diff] [review]
Context dummynode fix

Over in bug 671192, Neil suggested a possible workaround for the event handler having the same original prototype node by adding a dummy node to each main document.
This patch does that, once the core issue is fixed should be able to backout this patch where it lands.
Attachment #548488 - Flags: review?(neil)
(Assignee)

Comment 1

6 years ago
Created attachment 548557 [details] [diff] [review]
Reduced context dummy node fix [Checked in: trunk Comment 2 and comm-aurora/beta Comment 3]

Changes since last version:
* Only add dummy node to the one file as that is sufficient.
Attachment #548488 - Attachment is obsolete: true
Attachment #548488 - Flags: review?(neil)
Attachment #548557 - Flags: review?(neil)

Updated

6 years ago
Attachment #548557 - Flags: review?(neil) → review+
(Assignee)

Comment 2

6 years ago
Comment on attachment 548557 [details] [diff] [review]
Reduced context dummy node fix [Checked in: trunk Comment 2 and comm-aurora/beta Comment 3]

http://hg.mozilla.org/comm-central/rev/273d03134e26

Requesting approval to get into comm-aurora/beta to fix this issue.
Attachment #548557 - Attachment description: Reduced context dummy node fix → Reduced context dummy node fix [Checked in: Comment 2]
Attachment #548557 - Flags: approval-comm-beta?
Attachment #548557 - Flags: approval-comm-aurora?
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
status-seamonkey2.2: --- → affected
status-seamonkey2.3: --- → affected
status-seamonkey2.4: --- → affected
status-seamonkey2.5: --- → fixed
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.5

Updated

6 years ago
Attachment #548557 - Flags: approval-comm-beta?
Attachment #548557 - Flags: approval-comm-beta+
Attachment #548557 - Flags: approval-comm-aurora?
Attachment #548557 - Flags: approval-comm-aurora+
(Assignee)

Comment 3

6 years ago
Comment on attachment 548557 [details] [diff] [review]
Reduced context dummy node fix [Checked in: trunk Comment 2 and comm-aurora/beta Comment 3]

http://hg.mozilla.org/releases/comm-aurora/rev/12b3fc9c38d0
http://hg.mozilla.org/releases/comm-beta/rev/fc7414166518
Attachment #548557 - Attachment description: Reduced context dummy node fix [Checked in: Comment 2] → Reduced context dummy node fix [Checked in: trunk Comment 2 and comm-aurora/beta Comment 3]
(Assignee)

Updated

6 years ago
status-seamonkey2.3: affected → fixed
status-seamonkey2.4: affected → fixed
Target Milestone: seamonkey2.5 → seamonkey2.3

Updated

6 years ago
status-seamonkey2.5: fixed → ---
Target Milestone: seamonkey2.3 → seamonkey2.5

Comment 4

5 years ago
Bug 773945 fixed this so the patch can be backed out on trunk.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Updated

5 years ago
Target Milestone: seamonkey2.5 → ---

Comment 5

5 years ago
IanN: Time to back this out?
Flags: needinfo?(iann_bugzilla)
(Assignee)

Comment 6

5 years ago
Created attachment 696885 [details] [diff] [review]
Backout workaround [Checked in: Comment 7]

This backs out the workarounds for compose/composer code.
Attachment #696885 - Flags: review?(neil)
Flags: needinfo?(iann_bugzilla)

Updated

5 years ago
Attachment #696885 - Flags: review?(neil) → review+
(Assignee)

Comment 7

5 years ago
Comment on attachment 696885 [details] [diff] [review]
Backout workaround [Checked in: Comment 7]

http://hg.mozilla.org/comm-central/rev/fb8ce692fcab
Attachment #696885 - Attachment description: Backout workaround → Backout workaround [Checked in: Comment 7]
(Assignee)

Updated

5 years ago
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago5 years ago
status-seamonkey2.17: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.17
You need to log in before you can comment on or make changes to this bug.