674284 - Add nsTArray::SizeOf

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

For about:memory reporting usage.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/030c419226ed

Comment 2

[Marco Bonardo [:mak]]

this has been backed out
http://hg.mozilla.org/mozilla-central/rev/9517e7652dec

Comment 3

[[e-mail]]

Comment on attachment 548525 [details] [diff] [review]
Patch

>+  // @return The amount of memory taken used by this nsTArray, not including
>+  // sizeof(this)
>+  size_t SizeOf() const {
>+    return Capacity() * sizeof(elem_type) + sizeof(mHdr);
Except the mHdr is shared between non-auto nsTArrays...

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to comment #3)
> Comment on attachment 548525 [details] [diff] [review] [diff] [details] [review]
> Patch
> 
> >+  // @return The amount of memory taken used by this nsTArray, not including
> >+  // sizeof(this)
> >+  size_t SizeOf() const {
> >+    return Capacity() * sizeof(elem_type) + sizeof(mHdr);
> Except the mHdr is shared between non-auto nsTArrays...

That's only true if the nsTArray is empty, no?

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 548525 [details] [diff] [review]
Patch

This bounced with

../../../dist/include/nsTArray.h: In member function 'size_t nsTArray<E, Alloc>::SizeOf() const':
../../../dist/include/nsTArray.h:436:21: error: there are no arguments to 'Capacity' that depend on a template parameter, so a declaration of 'Capacity' must be available
../../../dist/include/nsTArray.h:436:21: note: (if you use '-fpermissive', G++ will accept your code, but allowing the use of an undeclared name is deprecated)
../../../dist/include/nsTArray.h:436:52: error: 'mHdr' was not declared in this scope

Not quite sure what to make of these ... it looks like base class members aren't in scope?

Comment 6

[Benjamin Smedberg]

You need this->Capacity. Bare names are not in scope in template classes that inherit from other templated classes. C++ is weird like that.

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Added the 'this' qualifiers.

http://hg.mozilla.org/mozilla-central/rev/bd93ca20e1fd