674309 - Missing Import in sut_lib tools

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[cmtalbert]

Attachment: simple fix

There's a missing import on the sut_lib.py tool.  If you don't have a - in your tegra name, you'll get a traceback noting that 'random' is not defined.

This fixes that.

Found while running installApp.py at my desk with SUT_NAME=fred

Patch attached.

Comment 1

[cmtalbert]

Is this something I can land any old time, or do I need to be careful as landing it could jeopardize things that are running?  Granted, it's not much of a consideration on this particular issue, I'm just asking so I know in general.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

normally I would say this would be safe, but if it changes some data because random actually produces something we could be hosed.  Maybe we can land this in staging?

Comment 3

[Aki Sasaki (not active)]

Please land whenever, it's just an import :)

Comment 4

[cmtalbert]

This code is only hit if the environment variable SUT_NAME does not contain a dash.  This should have 0 effect on our automation (we never fail out of the particular try/catch) and if we did, then we'd traceback.  This patch prevents the traceback from occuring.  So, at the moment, the code is broken as written.  This particular catch is the only use of random in the file.

Here is the location in detail:
http://mxr.mozilla.org/build/source/tools/sut_tools/sut_lib.py#303

Pushed: http://hg.mozilla.org/build/tools/rev/dc2ba6a83adc