Closed
Bug 674324
Opened 14 years ago
Closed 14 years ago
Remove leftover references to HAVE_CPP_MEMBER_TEMPLATES/HAVE_CPP_NUMERIC_LIMITS
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: gaston, Assigned: gaston)
Details
Attachments
(1 file)
1.90 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Followup to bug 499262, those two HAVE_CPP should have been removed too in http://hg.mozilla.org/mozilla-central/rev/e5f0916b32d3. The HAVE_CPP macros are not set by anything in configure/buildsystem, and googling for them yields nothing but that mozilla code.
Assignee | ||
Comment 1•14 years ago
|
||
Not even compile tested.. maybe needs a try run ?
Attachment #548554 -
Flags: review?(benjamin)
Assignee | ||
Updated•14 years ago
|
OS: OpenBSD → All
Hardware: x86 → All
Version: unspecified → Trunk
Comment 2•14 years ago
|
||
Comment on attachment 548554 [details] [diff] [review]
Remove leftovers
Yes, it should have a try run (build only) before landing.
Attachment #548554 -
Flags: review?(benjamin) → review+
Updated•14 years ago
|
Assignee: nobody → landry
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•14 years ago
|
||
Assignee | ||
Comment 4•14 years ago
|
||
Try run finished, i can't make any sense from the red linux build opt nor the b-m test failure, i've asked for a rebuild but it doesnt seem to do anything...
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 5•14 years ago
|
||
After asking for a bunch of single rebuilds, all is green. setting checkin-needed.
![]() |
||
Comment 6•14 years ago
|
||
Comment 7•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•14 years ago
|
||
Thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•