Closed Bug 674324 Opened 14 years ago Closed 14 years ago

Remove leftover references to HAVE_CPP_MEMBER_TEMPLATES/HAVE_CPP_NUMERIC_LIMITS

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: gaston, Assigned: gaston)

Details

Attachments

(1 file)

Followup to bug 499262, those two HAVE_CPP should have been removed too in http://hg.mozilla.org/mozilla-central/rev/e5f0916b32d3. The HAVE_CPP macros are not set by anything in configure/buildsystem, and googling for them yields nothing but that mozilla code.
Attached patch Remove leftoversSplinter Review
Not even compile tested.. maybe needs a try run ?
Attachment #548554 - Flags: review?(benjamin)
OS: OpenBSD → All
Hardware: x86 → All
Version: unspecified → Trunk
Comment on attachment 548554 [details] [diff] [review] Remove leftovers Yes, it should have a try run (build only) before landing.
Attachment #548554 - Flags: review?(benjamin) → review+
Assignee: nobody → landry
Status: NEW → ASSIGNED
Try run finished, i can't make any sense from the red linux build opt nor the b-m test failure, i've asked for a rebuild but it doesnt seem to do anything...
Keywords: checkin-needed
After asking for a bunch of single rebuilds, all is green. setting checkin-needed.
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla8
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Thanks!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: