Last Comment Bug 674324 - Remove leftover references to HAVE_CPP_MEMBER_TEMPLATES/HAVE_CPP_NUMERIC_LIMITS
: Remove leftover references to HAVE_CPP_MEMBER_TEMPLATES/HAVE_CPP_NUMERIC_LIMITS
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla8
Assigned To: Landry Breuil (:gaston)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-26 12:42 PDT by Landry Breuil (:gaston)
Modified: 2011-08-01 07:58 PDT (History)
4 users (show)
bzbarsky: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove leftovers (1.90 KB, patch)
2011-07-26 12:44 PDT, Landry Breuil (:gaston)
benjamin: review+
Details | Diff | Splinter Review

Description Landry Breuil (:gaston) 2011-07-26 12:42:20 PDT
Followup to bug 499262, those two HAVE_CPP should have been removed too in http://hg.mozilla.org/mozilla-central/rev/e5f0916b32d3. The HAVE_CPP macros are not set by anything in configure/buildsystem, and googling for them yields nothing but that mozilla code.
Comment 1 Landry Breuil (:gaston) 2011-07-26 12:44:46 PDT
Created attachment 548554 [details] [diff] [review]
Remove leftovers

Not even compile tested.. maybe needs a try run ?
Comment 2 Benjamin Smedberg [:bsmedberg] 2011-07-27 07:35:01 PDT
Comment on attachment 548554 [details] [diff] [review]
Remove leftovers

Yes, it should have a try run (build only) before landing.
Comment 3 Landry Breuil (:gaston) 2011-07-28 03:42:59 PDT
http://tbpl.mozilla.org/?tree=Try&rev=da747ad5fd37
Comment 4 Landry Breuil (:gaston) 2011-07-28 07:45:05 PDT
Try run finished, i can't make any sense from the red linux build opt nor the b-m test failure, i've asked for a rebuild but it doesnt seem to do anything...
Comment 5 Landry Breuil (:gaston) 2011-07-28 22:23:56 PDT
After asking for a bunch of single rebuilds, all is green. setting checkin-needed.
Comment 6 Boris Zbarsky [:bz] (still a bit busy) 2011-07-29 18:38:15 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/9e084a7e9cee
Comment 7 Marco Bonardo [::mak] 2011-08-01 07:52:33 PDT
http://hg.mozilla.org/mozilla-central/rev/9e084a7e9cee
Comment 8 Landry Breuil (:gaston) 2011-08-01 07:58:40 PDT
Thanks!

Note You need to log in before you can comment on or make changes to this bug.