674345 - Only load one necessary locale

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Benjamin Stover (:stechz)]

Currently we load all of them! On startup!

Comment 1

[Wil Clouser [:clouserw]]

(Forgive the diversion if this bug is about something else, but since you added it to bug 674253, I'll comment)

AMO provides https://addons.mozilla.org/en-US/mobile/api/1.5/get_language_packs which lists all of the language packs.  Since that page doesn't show the add-on id, you don't have a way of jumping to just showing the details of a single add-on, and at that point you'd have downloaded all the information for all of them anyway.

Is this bug about only showing a single add-on in the API from AMO or something else?

Comment 2

[Benjamin Stover (:stechz)]

Hi Wil,

Sorry for the confusion. I accidentally added the See Also from your bug to this bug, instead of the other way around.

This bug is about mobile startup time. If I understand correctly, once 674253 is fixed, we will no longer have multiple locales in Fennec until they are individually downloaded. So, this bug will be effectively fixed.

Comment 3

[Axel Hecht [:Pike]]

I don't think that we have any means to not load all add-ons that are installed at this point.

Also, what does "load" mean exactly?

Comment 4

[Benjamin Stover (:stechz)]

(In reply to comment #3)
> I don't think that we have any means to not load all add-ons that are
> installed at this point.

This is about the locales loading, not add-on loading.

Comment 5

[Benjamin Smedberg]

What does "load" mean in this context?

And I believe that what Axel is saying is that once the locales are individually downloaded, they will be addons, and we open addons JARs are startup to read their chrome.manifest (startupcache could help with this).

Is this bug about the future locales-as-addons case or the current all-locales-in-one case?

Comment 6

[Benjamin Stover (:stechz)]

(In reply to comment #5)
> What does "load" mean in this context?

Reading locales from disk on startup.

> And I believe that what Axel is saying is that once the locales are
> individually downloaded, they will be addons, and we open addons JARs are
> startup to read their chrome.manifest (startupcache could help with this).

OK. This makes sense.

> Is this bug about the future locales-as-addons case or the current
> all-locales-in-one case?

In general, only one locale should be loaded at startup. Locales as addons would solve this for most users, right? If that's the case, we could dupe this.

Comment 7

[Benjamin Smedberg]

Addons will *not* solve this, because we read at least the chrome.manifest from all addons at startup, and since most addons are JARred that means we read the entire JAR. Hence the comment about startup cache.

Since all of our files are in the omnijar (currently), if we didn't have addons are you proposing move locales into their own JAR separate from the omnijar? Does android let us do that?

Comment 8

[Axel Hecht [:Pike]]

also, given that omni.jars are optimized for the reads at startup, I'm not sure how much of omni.jar we really read, IO-wise. If that'd be a major issue for all the other things like pref dialogs and encryption detail UI, I don't think we'd go for omni.jar at all.

Comment 9

[Benjamin Stover (:stechz)]

(In reply to comment #7)
> Addons will *not* solve this, because we read at least the chrome.manifest
> from all addons at startup, and since most addons are JARred that means we
> read the entire JAR. Hence the comment about startup cache.

I believe I see the missing link here. Bug 668838 will make Fennec no longer ship with multiple locales. The user will choose her locale, which will be downloaded and installed.

Comment 10

[Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]]]

Per imelven we see no need for further review given the way locals are downloaded at this time. If this changes the need for a review may also change.

Comment 11

[BMO Automation]

Closing all opened bug in a graveyard component