Last Comment Bug 674541 - Test for DOM Worker Threads XHR (in dom/src/foo/) is still generated when using --disable-tests
: Test for DOM Worker Threads XHR (in dom/src/foo/) is still generated when usi...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla8
Assigned To: Ed Morley [:emorley]
:
Mentors:
Depends on:
Blocks: new-web-workers
  Show dependency treegraph
 
Reported: 2011-07-27 08:24 PDT by Ed Morley [:emorley]
Modified: 2011-07-30 13:22 PDT (History)
4 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (734 bytes, patch)
2011-07-27 08:29 PDT, Ed Morley [:emorley]
khuey: review-
Details | Diff | Splinter Review
Patch v2 (702 bytes, patch)
2011-07-27 10:07 PDT, Ed Morley [:emorley]
khuey: review+
Details | Diff | Splinter Review

Description Ed Morley [:emorley] 2011-07-27 08:24:33 PDT
Bug 649537 added dom/src/foo/test_foo.html, but the build system changes (http://hg.mozilla.org/mozilla-central/rev/8bf078002768) do not |ifdef ENABLE_TESTS|, so the test suite is still generated even when using --disable-tests.
Comment 1 Ed Morley [:emorley] 2011-07-27 08:29:15 PDT
Created attachment 548794 [details] [diff] [review]
Patch v1

Adds |ifdef ENABLE_TESTS| to the relevant section of dom/src/foo/Makefile.in
Comment 2 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-07-27 08:37:17 PDT
Comment on attachment 548794 [details] [diff] [review]
Patch v1

We don't even need to enter this directory if we're --disable-tests.
Comment 3 Ed Morley [:emorley] 2011-07-27 10:07:31 PDT
Created attachment 548819 [details] [diff] [review]
Patch v2

Changed to not enter dom/src/foo/ at all.

(Wasn't sure if foo was going to be used for non-test content at a later date, given the name wasn't obviously test based)

Thanks :-)
Comment 4 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-07-27 10:09:31 PDT
Comment on attachment 548819 [details] [diff] [review]
Patch v2

Nah, this directory is just to defeat tinderbox's test chunking setup.

r=me
Comment 5 Daniel Holbert [:dholbert] 2011-07-28 15:13:21 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/ea96c36c83e1
Comment 6 Marco Bonardo [::mak] 2011-07-29 03:10:19 PDT
http://hg.mozilla.org/mozilla-central/rev/ea96c36c83e1

Note You need to log in before you can comment on or make changes to this bug.