674541 - Test for DOM Worker Threads XHR (in dom/src/foo/) is still generated when using --disable-tests

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ed Morley [:emorley]]

Bug 649537 added dom/src/foo/test_foo.html, but the build system changes (http://hg.mozilla.org/mozilla-central/rev/8bf078002768) do not |ifdef ENABLE_TESTS|, so the test suite is still generated even when using --disable-tests.

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Adds |ifdef ENABLE_TESTS| to the relevant section of dom/src/foo/Makefile.in

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 548794 [details] [diff] [review]
Patch v1

We don't even need to enter this directory if we're --disable-tests.

Comment 3

[Ed Morley [:emorley]]

Attachment: Patch v2

Changed to not enter dom/src/foo/ at all.

(Wasn't sure if foo was going to be used for non-test content at a later date, given the name wasn't obviously test based)

Thanks :-)

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 548819 [details] [diff] [review]
Patch v2

Nah, this directory is just to defeat tinderbox's test chunking setup.

r=me

Comment 5

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/ea96c36c83e1

Comment 6

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/ea96c36c83e1