Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Test for DOM Worker Threads XHR (in dom/src/foo/) is still generated when using --disable-tests

RESOLVED FIXED in mozilla8

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
mozilla8
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Bug 649537 added dom/src/foo/test_foo.html, but the build system changes (http://hg.mozilla.org/mozilla-central/rev/8bf078002768) do not |ifdef ENABLE_TESTS|, so the test suite is still generated even when using --disable-tests.
(Assignee)

Comment 1

6 years ago
Created attachment 548794 [details] [diff] [review]
Patch v1

Adds |ifdef ENABLE_TESTS| to the relevant section of dom/src/foo/Makefile.in
Attachment #548794 - Flags: review?(khuey)
Comment on attachment 548794 [details] [diff] [review]
Patch v1

We don't even need to enter this directory if we're --disable-tests.
Attachment #548794 - Flags: review?(khuey) → review-
(Assignee)

Comment 3

6 years ago
Created attachment 548819 [details] [diff] [review]
Patch v2

Changed to not enter dom/src/foo/ at all.

(Wasn't sure if foo was going to be used for non-test content at a later date, given the name wasn't obviously test based)

Thanks :-)
Attachment #548794 - Attachment is obsolete: true
Attachment #548819 - Flags: review?(khuey)
Comment on attachment 548819 [details] [diff] [review]
Patch v2

Nah, this directory is just to defeat tinderbox's test chunking setup.

r=me
Attachment #548819 - Flags: review?(khuey) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Updated

6 years ago
Flags: in-testsuite-
http://hg.mozilla.org/integration/mozilla-inbound/rev/ea96c36c83e1
Keywords: checkin-needed
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
http://hg.mozilla.org/mozilla-central/rev/ea96c36c83e1
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.