674558 - Implement the HTML5 selectionDirection property for text controls (input and textarea)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

This is a new property for text controls which specifies the direction of the selection for text inputs and textareas.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[(no longer active)]

Attachment: Patch (v2)

Fixed a bug, and also added a couple of more tests.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 549127 [details] [diff] [review]
Patch (v2)

>--- a/content/html/content/src/nsHTMLInputElement.cpp
>+++ b/content/html/content/src/nsHTMLInputElement.cpp
>+      if (aDirection == NS_LITERAL_STRING("backward")) {

>--- a/content/html/content/src/nsHTMLTextAreaElement.cpp
>+++ b/content/html/content/src/nsHTMLTextAreaElement.cpp
>+      if (aDirection == NS_LITERAL_STRING("backward")) {

That's I signature you don't see often. How about EqualsListeral?

>--- a/toolkit/components/satchel/nsFormFillController.cpp
>+++ b/toolkit/components/satchel/nsFormFillController.cpp
>-    mFocusedInput->SetSelectionRange(aStartIndex, aEndIndex);
>+    mFocusedInput->SetSelectionRange(aStartIndex, aEndIndex, NS_LITERAL_STRING(""));

EmptyString()?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 549127 [details] [diff] [review]
Patch (v2)

>+++ b/content/base/public/nsISelectionPrivate.idl
>+     * (The return value is an nsDirection, and should be casted back to one

s/casted/cast/

That said, I think something like this would work cleaner:

  native nsDirection(nsDirection);

up front in the IDL and then

  [noscript, notxpcom] nsDirection getSelectionDirection();
  [noscript, notxpcom] void setSelectionDirection(nsDirection aDirection);

for the actual declaration.  That will give your C++ the function signature:

  nsDirection GetSelectionDirection();

I believe.

r=me with that.

Comment 5

[(no longer active)]

I filed http://www.w3.org/Bugs/Public/show_bug.cgi?id=13411 to fix the wording of the selectionEnd setting part in the spec.

Comment 6

[(no longer active)]

Attachment: Patch (v3)

Review comments addressed.

Comment 7

[Mounir Lamouri (:mounir)]

Comment on attachment 549144 [details] [diff] [review]
Patch (v3)

Review of attachment 549144 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/xpconnect/src/dom_quickstubs.qsconf
@@ +257,5 @@
>      'nsIDOMHTMLInputElement.files',
>      'nsIDOMHTMLInputElement.textLength',
>      'nsIDOMHTMLInputElement.selectionStart',
>      'nsIDOMHTMLInputElement.selectionEnd',
> +    'nsIDOMHTMLInputElement.selectionDirection',

Can't we have nsIDOMHTMLInputElement.*

@@ +317,5 @@
>      'nsIDOMHTMLTextAreaElement.select',
>      'nsIDOMHTMLTextAreaElement.setSelectionRange',
>      'nsIDOMHTMLTextAreaElement.selectionStart',
>      'nsIDOMHTMLTextAreaElement.selectionEnd',
> +    'nsIDOMHTMLTextAreaElement.selectionDirection',

Same for nsIDOMHTMLTextAreaElement.

Comment 8

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/e0c9fca2f500

Comment 9

[Eric Shepherd [:sheppy]]

Documentation updated:

https://developer.mozilla.org/en/HTML/Element/input
https://developer.mozilla.org/en/DOM/HTMLTextAreaElement
https://developer.mozilla.org/en/DOM/HTMLInputElement
https://developer.mozilla.org/en/DOM/Input.setSelectionRange
https://developer.mozilla.org/en/HTML/Element/textarea

And listed on Firefox 8 for developers.

Comment 10

[(no longer active)]

(In reply to Mounir Lamouri (:volkmar) from comment #7)
> Comment on attachment 549144 [details] [diff] [review]
> Patch (v3)
> 
> Review of attachment 549144 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/xpconnect/src/dom_quickstubs.qsconf
> @@ +257,5 @@
> >      'nsIDOMHTMLInputElement.files',
> >      'nsIDOMHTMLInputElement.textLength',
> >      'nsIDOMHTMLInputElement.selectionStart',
> >      'nsIDOMHTMLInputElement.selectionEnd',
> > +    'nsIDOMHTMLInputElement.selectionDirection',
> 
> Can't we have nsIDOMHTMLInputElement.*
> 
> @@ +317,5 @@
> >      'nsIDOMHTMLTextAreaElement.select',
> >      'nsIDOMHTMLTextAreaElement.setSelectionRange',
> >      'nsIDOMHTMLTextAreaElement.selectionStart',
> >      'nsIDOMHTMLTextAreaElement.selectionEnd',
> > +    'nsIDOMHTMLTextAreaElement.selectionDirection',
> 
> Same for nsIDOMHTMLTextAreaElement.

I don't see why we can't.  Would you mind filing a bug for that?