Do not kill child process when AndroidBridge is not available

RESOLVED FIXED in mozilla8

Status

()

Core
Widget: Android
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: alexp, Assigned: alexp)

Tracking

unspecified
mozilla8
ARM
Android
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Returning false from ContentParent::RecvXXX methods kills the child process. We should return true and handle the error gracefully if it's not really critical.
Methods to be fixed: RecvGetSystemColors, RecvGetIconForExtension.
Is not having the bridge a critical problem?  Sounds like it might be.
Assignee: alexp → nobody
Component: IPC → Widget: Android
QA Contact: ipc → android
(In reply to comment #1)
> Is not having the bridge a critical problem?  Sounds like it might be.

It is, but I don't see how killing the child process helps the situation.
No point in keeping the content process around if we're about to abort.  But you're right, doesn't matter much either way wrt content processes.
(Assignee)

Comment 4

6 years ago
(In reply to comment #1)
> Is not having the bridge a critical problem?  Sounds like it might be.

In general it is, but in these two specific cases inability to call those AndroidBridge functions is not really critical. The result would be only cosmetic: some things on the screen might look different, which I believe we can live with if everything else happens to be working.
(Assignee)

Updated

6 years ago
Assignee: nobody → alexp
Status: NEW → ASSIGNED
(Assignee)

Comment 5

6 years ago
Created attachment 548991 [details] [diff] [review]
Fix
Attachment #548991 - Flags: review?(blassey.bugs)
Attachment #548991 - Flags: review?(blassey.bugs) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Updated

6 years ago
Keywords: checkin-needed
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/33b34c07f8fc
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.