Last Comment Bug 674646 - Do not kill child process when AndroidBridge is not available
: Do not kill child process when AndroidBridge is not available
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: Widget: Android (show other bugs)
: unspecified
: ARM Android
-- normal (vote)
: mozilla8
Assigned To: Alex Pakhotin (:alexp)
:
: Jim Chen [:jchen] [:darchons]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-27 12:56 PDT by Alex Pakhotin (:alexp)
Modified: 2011-08-08 05:42 PDT (History)
3 users (show)
khuey: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix (1.85 KB, patch)
2011-07-27 17:36 PDT, Alex Pakhotin (:alexp)
blassey.bugs: review+
Details | Diff | Splinter Review

Description User image Alex Pakhotin (:alexp) 2011-07-27 12:56:05 PDT
Returning false from ContentParent::RecvXXX methods kills the child process. We should return true and handle the error gracefully if it's not really critical.
Methods to be fixed: RecvGetSystemColors, RecvGetIconForExtension.
Comment 1 User image Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-07-27 12:57:57 PDT
Is not having the bridge a critical problem?  Sounds like it might be.
Comment 2 User image Brad Lassey [:blassey] (use needinfo?) 2011-07-27 12:59:32 PDT
(In reply to comment #1)
> Is not having the bridge a critical problem?  Sounds like it might be.

It is, but I don't see how killing the child process helps the situation.
Comment 3 User image Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-07-27 13:04:42 PDT
No point in keeping the content process around if we're about to abort.  But you're right, doesn't matter much either way wrt content processes.
Comment 4 User image Alex Pakhotin (:alexp) 2011-07-27 15:46:27 PDT
(In reply to comment #1)
> Is not having the bridge a critical problem?  Sounds like it might be.

In general it is, but in these two specific cases inability to call those AndroidBridge functions is not really critical. The result would be only cosmetic: some things on the screen might look different, which I believe we can live with if everything else happens to be working.
Comment 5 User image Alex Pakhotin (:alexp) 2011-07-27 17:36:12 PDT
Created attachment 548991 [details] [diff] [review]
Fix
Comment 6 User image Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-08-08 05:42:08 PDT
http://hg.mozilla.org/mozilla-central/rev/33b34c07f8fc

Note You need to log in before you can comment on or make changes to this bug.