674791 - dragging the left text selection marker down selects to the bottom of the page

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Kevin Brosnan [Ex-Mozilla]]

Attachment: screenshot

1. open a page
2. select a word
3. drag the left selection marker down

results: from the right marker to the bottom of the page is selected

expected: selection should stay in the bounds of the markers

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Moving the left selection marker up seems to produce similar results.

Comment 2

[Martijn Wargers (dead)]

I assume you saw this on http://www.wired.com/threatlevel/2011/07/mit-webcam-swartz/ ?

Comment 3

[Martijn Wargers (dead)]

Ok, I can reproduce it on that url.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

The problem here is the cache.end position is "client" aligned and did not have the scrollOffset adjusted. The solution was to make sure the cache positions (start and end) were _always_ "client" oriented and to make the scrollOffset adjust in a local variable just for the mouse event.

That seems to fix the bug for me.

I also fixed bug 676008 by adjusting the initial x, y by scrollOffset too.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

Same as last but changed a selection.collaspeToStart() -? selection.removeAllRanges() to fix bug 675459 too.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mozilla-central/rev/5684f06138f3

Comment 7

[Aaron Train [:aaronmt]]

Verified Fixed
Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110805 Firefox/8.0a1 Fennec/8.0a1

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

This mobile-only patch makes some solid fixes to the text selection mechanism in Fx8 and we'd like to see it on Fx7 too.

Fixes are limited to only the 2 or 3 text selection methods. Low risk.

Comment 9

[Johnathan Nightingale [:johnath]]

Comment on attachment 550516 [details] [diff] [review]
patch 2

Get it landed this week, please

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/9d4a445ca235