Closed Bug 674791 Opened 10 years ago Closed 10 years ago

dragging the left text selection marker down selects to the bottom of the page

Categories

(Firefox for Android Graveyard :: General, defect, P3)

ARM
Android
defect

Tracking

(firefox7 fixed, firefox8 fixed)

VERIFIED FIXED
Firefox 7
Tracking Status
firefox7 --- fixed
firefox8 --- fixed

People

(Reporter: kbrosnan, Assigned: mfinkle)

References

()

Details

Attachments

(2 files, 1 obsolete file)

Attached image screenshot
1. open a page
2. select a word
3. drag the left selection marker down

results: from the right marker to the bottom of the page is selected

expected: selection should stay in the bounds of the markers
Moving the left selection marker up seems to produce similar results.
Ok, I can reproduce it on that url.
OS: Windows 7 → Android
Priority: -- → P3
Hardware: x86 → ARM
Attached patch patch (obsolete) — Splinter Review
The problem here is the cache.end position is "client" aligned and did not have the scrollOffset adjusted. The solution was to make sure the cache positions (start and end) were _always_ "client" oriented and to make the scrollOffset adjust in a local variable just for the mouse event.

That seems to fix the bug for me.

I also fixed bug 676008 by adjusting the initial x, y by scrollOffset too.
Assignee: nobody → mark.finkle
Attachment #550510 - Flags: review?(wjohnston)
Blocks: 674659
Attached patch patch 2Splinter Review
Same as last but changed a selection.collaspeToStart() -? selection.removeAllRanges() to fix bug 675459 too.
Attachment #550510 - Attachment is obsolete: true
Attachment #550510 - Flags: review?(wjohnston)
Attachment #550516 - Flags: review?(wjohnston)
Attachment #550516 - Flags: review?(wjohnston) → review+
pushed:
http://hg.mozilla.org/mozilla-central/rev/5684f06138f3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 675459
Blocks: 676008
Verified Fixed
Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110805 Firefox/8.0a1 Fennec/8.0a1
Status: RESOLVED → VERIFIED
Attachment #550516 - Flags: approval-mozilla-aurora?
This mobile-only patch makes some solid fixes to the text selection mechanism in Fx8 and we'd like to see it on Fx7 too.

Fixes are limited to only the 2 or 3 text selection methods. Low risk.
Comment on attachment 550516 [details] [diff] [review]
patch 2

Get it landed this week, please
Attachment #550516 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.