Last Comment Bug 674803 - Should remove needless G_OBJECT macro
: Should remove needless G_OBJECT macro
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: Plug-ins (show other bugs)
: Trunk
: All Linux
: -- normal (vote)
: mozilla8
Assigned To: Hiroyuki Ikezoe (:hiro)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-27 18:57 PDT by Hiroyuki Ikezoe (:hiro)
Modified: 2011-08-08 05:46 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix (2.74 KB, patch)
2011-07-27 18:57 PDT, Hiroyuki Ikezoe (:hiro)
karlt: review+
Details | Diff | Splinter Review

Description Hiroyuki Ikezoe (:hiro) 2011-07-27 18:57:21 PDT
Created attachment 549004 [details] [diff] [review]
Fix

g_signal_connect and g_object_unref accepts gpointer, so there is no need to add G_OBJECT.
Comment 1 Josh Aas 2011-08-04 21:54:32 PDT
Comment on attachment 549004 [details] [diff] [review]
Fix

Looks fine to me but I'd prefer that Karl look at it.
Comment 2 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-08-08 05:46:54 PDT
http://hg.mozilla.org/mozilla-central/rev/be8734f3c58f

Note You need to log in before you can comment on or make changes to this bug.