The default bug view has changed. See this FAQ.

Should remove needless G_OBJECT macro

RESOLVED FIXED in mozilla8

Status

()

Core
Plug-ins
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: hiro, Assigned: hiro)

Tracking

Trunk
mozilla8
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 549004 [details] [diff] [review]
Fix

g_signal_connect and g_object_unref accepts gpointer, so there is no need to add G_OBJECT.
(Assignee)

Updated

6 years ago
Summary: SHould remove needless G_OBJECT macro → Should remove needless G_OBJECT macro
(Assignee)

Updated

6 years ago
Attachment #549004 - Flags: review?(joshmoz)
Assignee: nobody → hiikezoe
Status: NEW → ASSIGNED
Version: unspecified → Trunk

Comment 1

6 years ago
Comment on attachment 549004 [details] [diff] [review]
Fix

Looks fine to me but I'd prefer that Karl look at it.
Attachment #549004 - Flags: review?(joshmoz) → review?(karlt)
Attachment #549004 - Flags: review?(karlt) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Updated

6 years ago
Keywords: checkin-needed
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/be8734f3c58f
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.