Closed Bug 674803 Opened 8 years ago Closed 8 years ago

Should remove needless G_OBJECT macro

Categories

(Core :: Plug-ins, defect)

All
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: hiro, Assigned: hiro)

Details

(Whiteboard: [inbound])

Attachments

(1 file)

Attached patch FixSplinter Review
g_signal_connect and g_object_unref accepts gpointer, so there is no need to add G_OBJECT.
Summary: SHould remove needless G_OBJECT macro → Should remove needless G_OBJECT macro
Attachment #549004 - Flags: review?(joshmoz)
Assignee: nobody → hiikezoe
Status: NEW → ASSIGNED
Version: unspecified → Trunk
Comment on attachment 549004 [details] [diff] [review]
Fix

Looks fine to me but I'd prefer that Karl look at it.
Attachment #549004 - Flags: review?(joshmoz) → review?(karlt)
Attachment #549004 - Flags: review?(karlt) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/be8734f3c58f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.