674811 - Puppet class names are relative

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

We have, abbreviated:

modules/puppet/manifests/master.pp:
 class puppet::master {
   include master
 }

modules/master/manifests/init.pp:
 class master {
   fail("hello")
 }

And

node "foo" {
  include puppet::master
}

In this case, the fail() is never seen; in fact, init.pp isn't even loaded.  Here's why: the |include master| in master.pp searches first for puppet::master, which it finds, so it stops searching.  I verified this by writing puppet::foober in modules/puppet/manifests/foober.pp, and observing that an 'include foober' in the puppet::master class definition will find that new foober.pp.

Kinda sucks, but hey, it's puppet.

So we should rename the 'master' module to something less generic.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

docs bug filed:
 https://projects.puppetlabs.com/issues/8669

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: m674811-puppet-manifests-p1-r1.patch

Easy change to releng::master, plus changes to the 'prefs' class.  This worked fine on scl-production-puppet-new (bug 659005)

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 549025 [details] [diff] [review]
m674811-puppet-manifests-p1-r1.patch

Review of attachment 549025 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Committed.