Last Comment Bug 674847 - Prevent tooltip suppression during drag from breaking tab clicking
: Prevent tooltip suppression during drag from breaking tab clicking
Product: Firefox
Classification: Client Software
Component: Tabbed Browser (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: Firefox 8
Assigned To: Frank Yan (:fryn)
: Dão Gottwald [:dao]
Depends on:
Blocks: 455694
  Show dependency treegraph
Reported: 2011-07-28 02:54 PDT by Yann Brelière
Modified: 2011-07-28 21:29 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (1.13 KB, patch)
2011-07-28 03:27 PDT, Frank Yan (:fryn)
dao+bmo: review-
Details | Diff | Splinter Review
patch v2 (2.10 KB, patch)
2011-07-28 04:22 PDT, Frank Yan (:fryn)
no flags Details | Diff | Splinter Review
patch v3 (1.97 KB, patch)
2011-07-28 16:08 PDT, Frank Yan (:fryn)
dao+bmo: review+
Details | Diff | Splinter Review

Description Yann Brelière 2011-07-28 02:54:55 PDT
I clicked and hold a tab, but instead of dragging the tab, it dragged the entire window.
I'm using Ubuntu's default theme, Ambiance, which allows dragging windows from the menubar, and in the case of Firefox, allows dragging the window from the unified tab bar. Except that now, it drags from any tab, not just the background bar.

As long as I don't try dragging a tab, there is no problems, but as soon as I try and fail dragging a tab, I can now no longer even click on a tab to focus it (it grabs and releases the window during the click), and if I right-click on any tab, it displays the toolbar's context menu instead of the tab's.
So if want to be able to pin tabs or switch tabs with the mouse, I have to restart Firefox and refrain from trying to initiate a tab drag.

Related to Bug 455694 and Bug 635397.
Comment 1 Frank Yan (:fryn) 2011-07-28 03:27:09 PDT
Created attachment 549055 [details] [diff] [review]
Comment 2 Dão Gottwald [:dao] 2011-07-28 04:08:56 PDT
Comment on attachment 549055 [details] [diff] [review]

Disabling all pointer events while the user clicks on the tab bar, really? This seems a bit too magical, fragile and like it could have various unforeseen effects (like this bug!). Suppressing tooltips while dragging can be done in createTooltip, right?
Comment 3 Frank Yan (:fryn) 2011-07-28 04:22:53 PDT
Created attachment 549067 [details] [diff] [review]
patch v2

True, but we still need to work around bug 666864.
Comment 4 Dão Gottwald [:dao] 2011-07-28 04:29:37 PDT
(In reply to comment #3)
> Created attachment 549067 [details] [diff] [review] [review]
> patch v2
> True, but we still need to work around bug 666864.

Well, or talk to the right people to actually get it fixed. (If it's still an issue, then it's no drag-and-drop bug, since you're not using that API anymore.)
Comment 5 Frank Yan (:fryn) 2011-07-28 16:08:59 PDT
Created attachment 549261 [details] [diff] [review]
patch v3

Oh, oops. Bug 666864 doesn't occur for mouse-event-based operations.
I thought I had reproduced it, but I had accidentally run my build for bug 674925.
Comment 6 Frank Yan (:fryn) 2011-07-28 21:29:21 PDT
Pushed to m-c instead of fx-team to get this in the next nightly.

Note You need to log in before you can comment on or make changes to this bug.