674861 - contentEditable lists should not be splittable

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Fabien Cazenave [:kaze]]

In design mode, pressing [Return] twice in a list (ol, ul, dl) splits the list and inserts a paragraph. When the list is the active editing host, it should not be split.

Reproducible: Always

Steps to Reproduce:
1. create an empty HTML file with the following code:
    <ul contenteditable>
        <li> foo </li>
        <li> bar </li>
    </ul>
2. put the caret at the end of the first list item
3. press [Return] twice
4. the resulting code is:
    <ul contenteditable>
        <li> foo </li>
    </ul>
    <p> <br _moz_dirty> </p>
    <ul contenteditable>
        <li> bar </li>
    </ul>

Expected Results:
    <ul contenteditable>
        <li> foo </li>
        <li> <br _moz_dirty> </li>
        <li> <br _moz_dirty> </li>
        <li> bar </li>
    </ul>

Comment 1

[Fabien Cazenave [:kaze]]

bug 597349 and bug 570144 might be related.

Comment 2

[Fabien Cazenave [:kaze]]

Attachment: patch proposal

Comment 3

[Fabien Cazenave [:kaze]]

Attachment: testcase

Comment 4

[Fabien Cazenave [:kaze]]

Attachment: patch proposal

slightly factorized code + unit tests

Comment 5

[(no longer active)]

Comment on attachment 549839 [details] [diff] [review]
patch proposal

Review of attachment 549839 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLEditRules.cpp
@@ +6782,2 @@
>    // if we are in an empty listitem, then we want to pop up out of the list
> +  // but only if prefs says it's ok and if the parent isn't the active editing host.

Nit: if the list container isn't the active editing host.

Comment 6

[Fabien Cazenave [:kaze]]

Attachment: patch proposal

same patch w/ fixed comment.

Comment 7

[(no longer active)]

Comment on attachment 550096 [details] [diff] [review]
patch proposal

(You didn't really need a review for this one :-)

Comment 8

[(no longer active)]

Pushed to inbound.

Comment 9

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/6ea906365d1f