674874 - Mozmill test for installing an add-on from a FTP server

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Maniac Vlad Florin (:vladmaniac)]

Tracking bug for testing installation of an add-on via FTP server. 
Litmus test: https://litmus.mozilla.org/show_test.cgi?id=17240

Comment 1

[u415141]

A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/16350843

Comment 2

[Maniac Vlad Florin (:vladmaniac)]

Attachment: patch v1.0 for release branch

Uploading initial patch

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Vlad, please file a bug under Mozilla QA / Infrastructure so we can get an FTP server setup on mozqa.com. We don't want to use external servers as best as possible. Thanks.

Comment 4

[u279076]

(In reply to comment #3)
> Vlad, please file a bug under Mozilla QA / Infrastructure so we can get an
> FTP server setup on mozqa.com. We don't want to use external servers as best
> as possible. Thanks.

Also, don't forget to mark it as a dependency for this bug.

Comment 5

[Maniac Vlad Florin (:vladmaniac)]

Will do guys, thanks!

Comment 6

[u279076]

Comment on attachment 549114 [details] [diff] [review]
patch v1.0 for release branch

Canceling review until we can get the dependency resolved. Drive-by style review looks fine.

Comment 7

[Maniac Vlad Florin (:vladmaniac)]

Attachment: wip patch 1.0

Yey we have a ftp server for mozqa. 

This wip patch does the following: 

- goes to the ftp page 
- installs the first add-on from the list (in this case empty.xpi) 
- checks that empty.xpi is installed 

Do we plan to change the page in the near future? If so, i guess we need to change this test 
to work for a random add-on somehow. Henrik, what do you think? 

What we should have: 

- Go to the ftp page test 1.js
- Install a random add-on test1.js
- Identify on which add-on did we click to install test1.js 
- Verify if the add-on was installed test2.js

Better ideas are highly appreciated

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 568772 [details] [diff] [review]
wip patch 1.0

>+const FTP_SERVER = "ftp://ftp.mozqa.com";

Please don't introduce new variable names. It has to be consistent with all the other tests.

>+const ADDON_PAGE = FTP_SERVER + "/data/firefox/addons/extensions/";

We have to wait until the dependency bug has been fully fixed. Also reference the extension to install directly.

>+  var nodeCollector = new domUtils.nodeCollector(controller.tabs.activeTab);
>+  nodeCollector.queryNodes("tr a");
>+  
>+  var md = new modalDialog.modalDialog(addonsManager.controller.window);
>+  var linkCount = nodeCollector.elements.length;
>+  var addonLink = nodeCollector.elements[3];

All that is not necessary.

>+const ADDON_ID = "[e-mail]";

As usual please use persisted and set the id in the first test module.

>+  assert.ok(addonsManager.isAddonInstalled({addon: addon}), 
>+            "Addon " + ADDON_ID + " has been correctly installed");

nit: add ' around the id.

Comment 9

[Maniac Vlad Florin (:vladmaniac)]

Well the dependency bug was marked as fixed when i provided the patch. Guess i was too fast 

I will just wait for the dependency to be completely fixed then address to your other comments. 

Thanks for f!

Comment 10

[Maniac Vlad Florin (:vladmaniac)]

Attachment: patch v1.0 all branches [checked-in]

Fixed. 

We are now installing from mozqa ftp server. 
The add-on is installed directly (direct ftp link to xpi file)

Comment 11

[Maniac Vlad Florin (:vladmaniac)]

We do not depend on bug 675163 even if its reopened as stated in https://bugzilla.mozilla.org/show_bug.cgi?id=675163#c17

Comment 12

[u279076]

Comment on attachment 576736 [details] [diff] [review]
patch v1.0 all branches [checked-in]

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/9959cd32ad6f (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/910f3337538f (mozilla-aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/27f4ce46667d (mozilla-beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/d85845e3a2a4 (mozilla-release)

Comment 13

[u279076]

Please verify with tomorrow's test run.