Last Comment Bug 674890 - Update WebSocket API to latest draft - send() should return void
: Update WebSocket API to latest draft - send() should return void
Status: RESOLVED FIXED
[inbound]
: dev-doc-complete
Product: Core
Classification: Components
Component: Networking: WebSockets (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla8
Assigned To: Patrick McManus [:mcmanus]
:
Mentors:
Depends on:
Blocks: 666349
  Show dependency treegraph
 
Reported: 2011-07-28 06:23 PDT by Patrick McManus [:mcmanus]
Modified: 2011-08-24 08:05 PDT (History)
9 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v1 (2.76 KB, patch)
2011-07-28 11:59 PDT, Patrick McManus [:mcmanus]
jonas: review+
bzbarsky: superreview+
Details | Diff | Review

Description Patrick McManus [:mcmanus] 2011-07-28 06:23:51 PDT
+++ This bug was initially created as a clone of Bug #666349 +++

We return a boolean from send() instead of void.
Comment 1 Patrick McManus [:mcmanus] 2011-07-28 11:59:46 PDT
Created attachment 549187 [details] [diff] [review]
patch v1
Comment 2 Jonas Sicking (:sicking) 2011-08-02 10:22:11 PDT
Comment on attachment 549187 [details] [diff] [review]
patch v1

Review of attachment 549187 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Comment 3 Patrick McManus [:mcmanus] 2011-08-02 11:45:35 PDT
Comment on attachment 549187 [details] [diff] [review]
patch v1

idl change.. sr?
Comment 4 Boris Zbarsky [:bz] 2011-08-02 11:49:58 PDT
Comment on attachment 549187 [details] [diff] [review]
patch v1

sr=me
Comment 5 Marco Bonardo [::mak] 2011-08-03 02:19:43 PDT
http://hg.mozilla.org/mozilla-central/rev/d5ada3bd3ad5
Comment 6 Eric Shepherd [:sheppy] 2011-08-24 08:05:43 PDT
Updated the docs by revising the note on the send() method:

https://developer.mozilla.org/en/WebSockets/WebSockets_reference/WebSocket#send%28%29

Also mentioned on Firefox 8 for developers.

Note You need to log in before you can comment on or make changes to this bug.