Closed Bug 674942 Opened 14 years ago Closed 14 years ago

Mailnews part of cookie code still gets built as MOZ_MAIL_NEWS is not configured correctly

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

Attachments

(1 file)

Attached patch Fix configure.inSplinter Review
Currently MOZ_MAIL_NEWS ends up defined as @MOZ_MAIL_NEWS@ which equates to true so, even though mailnews code is ifdef'd out in the cookie code, it still gets built. This patch, hopefully, fixes that by: * Adding two lines to configure.in to make sure that MOZ_MAIL_NEWS is not defined.
Attachment #549140 - Flags: review?(dwitte)
In bug 557047, I'm proposing on changing the way it works and removing the MOZ_MAIL_NEWS option completely.
Attachment #549140 - Flags: review?(dwitte) → review?(khuey)
Comment on attachment 549140 [details] [diff] [review] Fix configure.in I was going to say this should get review from a cookies peer, but the changes on the cookies side are trivial enough that I don't think that's necessary. r=me
Attachment #549140 - Flags: review?(khuey) → review+
Bug 557047 removed the need for this by reworking the code so that MOZ_MAIL_NEWS is no longer required and the mailnews options are flags set by protocols in mailnews.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → WORKSFORME
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: