675008 - We check for the deployment target version, but should check for the sdk version

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: check for the sdk version

With 673789 fixed a build with

ac_add_options --with-macos-sdk=/Developer/SDKs/MacOSX10.7.sdk
ac_add_options --enable-macos-target=10.5

would still fail since MAC_OS_X_VERSION_MIN_REQUIRED is 10.5 which is < 10.7.

I think the correct fix that works with both configure and xcode is to use MAC_OS_X_VERSION_MAX_ALLOWED which is defined to the sdk version.

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

I added a checking-needed, let me know if we should wait for this to be upstream instead.

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to comment #1)
> I added a checking-needed

When using "checkin-needed", it's best if you...
 (a) make sure the patch has the right level of directory depth for |hg import| to work.
 (b) include author & commit-message headers, as described here:
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f

(You can use mq to address (b), as described at the above URL, or alternately you apply the changes and do "hg commit" (as if you were going to push it), and then "hg export tip > my_patch.patch", and then attach my_patch.patch.  And finally you can use "hg rollback" to undo the commit.)

> let me know if we should wait for this to be upstream instead.

Assuming that we're not waiting for upstream (ted?) -- Rafael, it'd greatly help whoever ultimately checks this in if you could address (a) and (b) above, so that this is more pushable.

Comment 3

[Daniel Holbert [:dholbert]]

(Either of the suggested fixes for (b) will also fix (a) for free, btw.)

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: hg and commiter friendly version of the previous patch.

Comment 5

[(no longer active)]

Landed on inbound.

Comment 6

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/272a5a897bb6