Last Comment Bug 675037 - async fullzoom callback needs to handle being called after window is destroyed
: async fullzoom callback needs to handle being called after window is destroyed
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 8
Assigned To: :Gavin Sharp [email: gavin@gavinsharp.com]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-28 14:16 PDT by :Gavin Sharp [email: gavin@gavinsharp.com]
Modified: 2011-08-02 05:28 PDT (History)
2 users (show)
gavin.sharp: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.21 KB, patch)
2011-07-28 14:19 PDT, :Gavin Sharp [email: gavin@gavinsharp.com]
dolske: review+
Details | Diff | Splinter Review

Description :Gavin Sharp [email: gavin@gavinsharp.com] 2011-07-28 14:16:34 PDT
It uses browser.currentURI, which can be null if the callback runs after the window is destroyed. nsIURI::equals doesn't like that, and complains:

Error: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://browser/content/browser.js :: <TOP_LEVEL> :: line 338"  data: no]
Source File: chrome://browser/content/browser.js
Line: 338
Comment 1 :Gavin Sharp [email: gavin@gavinsharp.com] 2011-07-28 14:19:50 PDT
Created attachment 549223 [details] [diff] [review]
patch
Comment 2 :Gavin Sharp [email: gavin@gavinsharp.com] 2011-08-01 14:27:43 PDT
https://hg.mozilla.org/integration/fx-team/rev/30e5fe8a62c2
Comment 3 Tim Taubert [:ttaubert] 2011-08-02 05:28:57 PDT
http://hg.mozilla.org/mozilla-central/rev/30e5fe8a62c2

Note You need to log in before you can comment on or make changes to this bug.