Closed Bug 675037 Opened 13 years ago Closed 13 years ago

async fullzoom callback needs to handle being called after window is destroyed

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 8

People

(Reporter: Gavin, Assigned: Gavin)

Details

Attachments

(1 file)

patch
1.21 KB, patch
Dolske
: review+
Details | Diff | Splinter Review 
It uses browser.currentURI, which can be null if the callback runs after the window is destroyed. nsIURI::equals doesn't like that, and complains:

Error: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://browser/content/browser.js :: <TOP_LEVEL> :: line 338"  data: no]
Source File: chrome://browser/content/browser.js
Line: 338
Attached patch patch — — Splinter Review 
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED

        Attachment #549223 -
        Flags: review?(dolske)

        Attachment #549223 -
        Flags: review?(dolske) → review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/30e5fe8a62c2
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: