async fullzoom callback needs to handle being called after window is destroyed

RESOLVED FIXED in Firefox 8

Status

()

Firefox
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Gavin, Assigned: Gavin)

Tracking

Trunk
Firefox 8
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

It uses browser.currentURI, which can be null if the callback runs after the window is destroyed. nsIURI::equals doesn't like that, and complains:

Error: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://browser/content/browser.js :: <TOP_LEVEL> :: line 338"  data: no]
Source File: chrome://browser/content/browser.js
Line: 338
Created attachment 549223 [details] [diff] [review]
patch
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #549223 - Flags: review?(dolske)
Attachment #549223 - Flags: review?(dolske) → review+
https://hg.mozilla.org/integration/fx-team/rev/30e5fe8a62c2
Flags: in-testsuite-
http://hg.mozilla.org/mozilla-central/rev/30e5fe8a62c2
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
You need to log in before you can comment on or make changes to this bug.