67504 - Hardcoded English in mimedrft.cpp

Status: RESOLVED FIXED

(MailNews Core :: MIME, defect, P3)

Description

[Mike Kaply [:mkaply]]

The string Original Message is hardcoded multiple times in mimedrft.cpp.

This needs to be in a properties file.

http://lxr.mozilla.org/seamonkey/source/mailnews/mime/src/mimedrft.cpp#600
http://lxr.mozilla.org/seamonkey/source/mailnews/mime/src/mimedrft.cpp#605
http://lxr.mozilla.org/seamonkey/source/mailnews/mime/src/mimedrft.cpp#612
http://lxr.mozilla.org/seamonkey/source/mailnews/mime/src/mimedrft.cpp#755
http://lxr.mozilla.org/seamonkey/source/mailnews/mime/src/mimedrft.cpp#761
http://lxr.mozilla.org/seamonkey/source/mailnews/mime/src/mimedrft.cpp#933
http://lxr.mozilla.org/seamonkey/source/mailnews/mime/src/mimedrft.cpp#939

Comment 1

[Jean-Francois Ducarroz]

good catch.

Comment 2

[scottputterman]

removing mozilla0.9 milestone and nominating for nsbeta1.

Comment 3

[scottputterman]

marking nsbeta1+ and moving to mozilla0.9

Comment 4

[scottputterman]

moving to mozilla0.9.1

Comment 5

[Jean-Francois Ducarroz]

Attachment: proposed path

Comment 6

[Jean-Francois Ducarroz]

R=varada

Comment 7

[David :Bienvenu]

sr=bienvenu

Comment 8

[Jean-Francois Ducarroz]

Fixed and checked in

Comment 9

[(not reading, please use [e-mail] instead)]

this might not be over.

as with bug #23615, it is not always desirable to use localized strings.  there
are cases where a japanese user would need the ASCII version

nhotta knows all about this.

Comment 10

[nhottanscp]

The user who is using the localized version may forward a mail which does not
match with the localized language.
For example, when forwarding US-ASCII message, you may not want to put Japanese
string in the message.
So the pref proposed in bug 23615 also has to be used for this forward inline case.

Comment 11

[(not reading, please use [e-mail] instead)]

we need to do the same thing we need for #23615 

1) add a hidden pref (shared by the code we'll write for #23615) to say if the
inserted text should be ASCII version or the localized version
2) add another property to mime.properties that has a localization note "DO NOT
LOCALIZE THIS"
3) fix the code to check the pref to decide what to insert.

nhotta, should the default be "use ASCII" or "use localized"?

let's take this to another bug, instead of reopening this one.

Comment 12

[Andreas Becker]

Changing QA contact to ftang. Frank, can this be verified within development?
Otherwise please provide QA with a test case.

Comment 13

[nhottanscp]

qa contact to nhotta for now, this needs localized build to veriry