675116 - shrink mozilla-{,pre}releases exclude files with globs and other regexes

Status: RESOLVED WONTFIX

(Release Engineering :: Release Automation, defect, P3)

Description

[[e-mail] (:bhearsum)]

These files currently have a very verbose list of releases to not serve. we could shrink it considerably by globbing things like 3.0*, *.*a*, and probably other things.

Comment 1

[[e-mail] (:bhearsum)]

Maybe we can do this at the same time as bug 736464. What do you think Rail?

Comment 2

[Rail Aliiev [:rail]]

(In reply to Ben Hearsum [:bhearsum] from comment #1)
> Maybe we can do this at the same time as bug 736464. What do you think Rail?

Good idea.

Comment 3

[Rail Aliiev [:rail]]

Attachment: shrink it!

I tested the changes using the following method:

1) Canonical output:
 rsync -avn --filter ". /pub/mozilla.org/zz/rsyncd-mozilla-prereleases.exclude" /pub/mozilla.org/ tmp/ > before
2) New output:
 rsync -avn --filter ". rsyncd-mozilla-prereleases.exclude" /pub/mozilla.org/ tmp/ > after
3) diff -u before after

The diffs look fine:
-sent 3268040 bytes  received 400723 bytes  59654.68 bytes/sec
+sent 3268040 bytes  received 400723 bytes  69881.20 bytes/sec

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 638577 [details] [diff] [review]
shrink it!

On the whole this looks pretty good to me, as the wildcards are mostly a welcome way to squash a lot of lines, and I like the check you did (assuming it was for both modules!). In some cases it's less obvious what's going on and I've mentioned those inline. I'm also keen to make the diff's between the two manifests as minimal as possible, since I use that as a check whenever I remove files from the mirrors.

>Index: rsyncd-mozilla-prereleases.exclude
>===================================================================
>+- firefox/releases/3.?

This blocks 3.0, 3.5, 3.6 - I'd rather still have those explicitly next to the other lines for those branches.

>+- thunderbird/releases/3.?

Same comment as just above.

>+- thunderbird/releases/3.?
>+- thunderbird/releases/3.?.?

These are repeated from earlier.

>Index: rsyncd-mozilla-releases.exclude
>===================================================================
>+- firefox/releases/deerpark
>+- firefox/releases/devpreview
>+- firefox/releases/granparadiso
>+- firefox/releases/namoroka
>+- firefox/releases/partners
>+- firefox/releases/shiretoko

Please order this block the same as in the prereleases, to make diffing easier.

>+- firefox/releases/1.*
>+- firefox/releases/1.*

Duplicate lines.

>+- firefox/releases/3.6.?/

Any particular reason for a / here ?

>+- firefox/releases/3.6.1*

Swap the ? to * to match prereleases

> - firefox/releases/13.0.2

This can go now that 13.0.2 is dead, or I can do it in the next cleanup I do if you prefer to simplify only.

>+- seamonkey/releases/2.0.*
>+- seamonkey/releases/2.3.*
>+- seamonkey/releases/2.7.*
etc

I think you can collapse this down to the same set of wildcards as prerelease, since only 2.10* have any chance of being on internal or external mirrors (ie 2.?.? doesn't match). Similarly calendar/lightning.

Comment 5

[Rail Aliiev [:rail]]

I'm not sure that I can work on this this month. Back to the pool, sorry. :(

Comment 6

[[e-mail] (:bhearsum)]

It's okay, not a big priority, especially because we rarely touch these files anymore.

Comment 7

[[e-mail] (:bhearsum)]

These files aren't really used at all anymore.