After update, tabs are restored, but not loaded, except the first one Error: uncaught exception: nsISHEntry.stateData in nsSessionStore.js :: sss_deserializeHistoryEntry :: line 2827

RESOLVED FIXED in seamonkey2.5

Status

SeaMonkey
Session Restore
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: Misak Khachatryan)

Tracking

Trunk
seamonkey2.5
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.3 fixed, seamonkey2.4 fixed, seamonkey2.5 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
After getting updated to Seamonkey 2.3, my tabs were restored, but the urls weren't loaded, leaving all tabs empty, except for the first one.

Neil Rashbrook did let me do some investigation.
I'm seeing the same error with the sessionstore.json file (new profile) in the latest Seamonkey trunk build.
I'm not seeing this error using this sessionstore.json file with the latest Firefox desktop trunk build (after having it renamed to sessionstore.js).
So I guess Firefox contains already a fix for this error situation.

I noticed this error in the error console using the lates Seamonkey trunk build:
Error: uncaught exception: [Exception... "Could not convert JavaScript argument arg 0 [nsISHEntry.stateData]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: jar:file:///C:/Users/mw22/Desktop/seamonkey-2.5a1.en-US.win32/seamonkey/omni.jar!/components/nsSessionStore.js :: sss_deserializeHistoryEntry :: line 2827"  data: no]

I haven't attached the sessionstore.json file, because I don't know if it contains sensitive data, but if someone needs to have it in order to be able to fix it, let me know and I'll mail it to you.
(Reporter)

Updated

6 years ago
Summary: After update, tabs are restored, but not loaded, except the first one Error: uncaught exception: nsISHEntry.stateDat in nsSessionStore.js :: sss_deserializeHistoryEntry :: line 2827 → After update, tabs are restored, but not loaded, except the first one Error: uncaught exception: nsISHEntry.stateData in nsSessionStore.js :: sss_deserializeHistoryEntry :: line 2827

Comment 1

6 years ago
We need to port parts of bug 551225.
(Assignee)

Updated

6 years ago
Assignee: nobody → misak.bugzilla
Depends on: 551225
OS: Windows 7 → All
Hardware: x86 → All
(Assignee)

Comment 2

6 years ago
Created attachment 549573 [details] [diff] [review]
patch

patch, incorporates also missed fix from bug 647028.
Attachment #549573 - Flags: review?(neil)
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
Depends on: 647028

Comment 3

6 years ago
Comment on attachment 549573 [details] [diff] [review]
patch

>-    if (aEntry.stateData) {
>+    if (aEntry.stateData != null) {
I don't see the point of this change.
Attachment #549573 - Flags: review?(neil) → review+
(Assignee)

Comment 4

6 years ago
(In reply to comment #3)
> I don't see the point of this change.

It's time for me to stop blindly copying code :(

Pushed with nit fixed:
http://hg.mozilla.org/comm-central/rev/a7169a94d871
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Misak, the reporter was talking about SM 2.3 in the beginning. If this needs to be backported to aurora/beta, please request accordingly. We still have a chance to land things for 2.3, but it won't be long and the door will close.

Comment 6

6 years ago
Comment on attachment 549573 [details] [diff] [review]
patch

The parent m-c bug 551225 will be in Firefox 6 so this should land on comm-beta as well I think.
Attachment #549573 - Flags: approval-comm-beta?
Attachment #549573 - Flags: approval-comm-aurora?

Comment 7

6 years ago
Comment on attachment 549573 [details] [diff] [review]
patch

a=me
Attachment #549573 - Flags: approval-comm-beta?
Attachment #549573 - Flags: approval-comm-beta+
Attachment #549573 - Flags: approval-comm-aurora?
Attachment #549573 - Flags: approval-comm-aurora+
(Assignee)

Comment 8

6 years ago
http://hg.mozilla.org/releases/comm-beta/rev/6725e0f394f6
http://hg.mozilla.org/releases/comm-aurora/rev/56aa3a1b61e2
Target Milestone: --- → seamonkey2.3
Version: unspecified → Trunk

Updated

6 years ago
status-seamonkey2.3: --- → fixed
status-seamonkey2.4: --- → fixed
Target Milestone: seamonkey2.3 → seamonkey2.5

Updated

6 years ago
status-seamonkey2.5: --- → fixed
You need to log in before you can comment on or make changes to this bug.