675171 - standardize font weight for field labels

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[:glob ✱]

Attachment: mixed label weights

currently different field labels have different font weights.  this difference isn't immediately noticeable with the default font (verdana), however it becomes evident when switching to more modern fonts.

we have:
  <td><b> (weight 900)
  <th><label> (weight 700)
  <td><label><b> (weight 900)
the standard weight is 400.

Comment 1

[:glob ✱]

the fix should be to:

  - make all the field labels use <th>
  - drop the <b> tag

or

  - make all the field labels use <td>
  - drop the <b> tag
  - use css to style the field_labels as bold

Comment 2

[David Lawrence [:dkl]]

(In reply to comment #1)
>   - make all the field labels use <td>
>   - drop the <b> tag
>   - use css to style the field_labels as bold

+1

Comment 3

[Max Kanat-Alexander]

The field labels are logically table headers and so should logically be <th> fields. They should all have the field_label class on them, also, which handles this one way or another.

We should *definitely* remove the <b> tags.

Comment 4

[David Lawrence [:dkl]]

Attachment: Patch to fix field_label elements in edit.html.tmpl

Comment 5

[:glob ✱]

Comment on attachment 654377 [details] [diff] [review]
Patch to fix field_label elements in edit.html.tmpl

r=glob, with the following fixed on commit:

>-      <td class="field_label">
>+      <th class="field_label">
>         <label for="keywords" accesskey="k">
>-          <b><a href="describekeywords.cgi"><u>K</u>eywords</a></b></label>:
>+          <a href="describekeywords.cgi"><u>K</u>eywords</a></label>:
>       </td>

this </td> needs to be a </th>

Comment 6

[David Lawrence [:dkl]]

(In reply to Byron Jones ‹:glob› from comment #5)
> this </td> needs to be a </th>

Thanks. Will fix on commit.

dkl

Comment 7

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk
modified template/en/default/bug/edit.html.tmpl
Committed revision 8385.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4
modified template/en/default/bug/edit.html.tmpl
Committed revision 8383.