Last Comment Bug 675191 - Cached dynamic overlays still get saved to fastload (startup cache)
: Cached dynamic overlays still get saved to fastload (startup cache)
: assertion
Product: Core
Classification: Components
Component: XUL (show other bugs)
: unspecified
: All All
-- normal (vote)
: ---
Assigned To:
: Neil Deakin
Depends on: 520309
  Show dependency treegraph
Reported: 2011-07-29 06:26 PDT by
Modified: 2011-08-07 06:05 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Proposed patch (1.11 KB, patch)
2011-07-29 06:38 PDT,
enndeakin: review+
Details | Diff | Splinter Review

Description User image 2011-07-29 06:26:54 PDT
When loading cached XUL dynamic overlays the document gets saved to the startup cache even though it had been already put in the startup cache when the overlay was originally cached.

Steps to reproduce problem:
1. Open a XUL document that uses dynamic overlays
2. Close and reopen the document

Expected result: Startup cache written once

Actual result: Startup cache written twice

Additional information:
###!!! ASSERTION: Existing entry in StartupCache.: 'entry == nsnull', file startupcache/StartupCache.cpp, line 298

Presumably the old fastload cache didn't do the check.
Comment 1 User image 2011-07-29 06:38:16 PDT
Created attachment 549356 [details] [diff] [review]
Proposed patch

We should only set mIsFastLoad if we're actually doing a load. We already do this correctly in the two places where we trigger loads (later on in this method and also in StartDocumentLoad). So the code snippet is bogus.
Comment 2 User image 2011-08-07 06:05:52 PDT
Pushed changeset ed772265d2bc to mozilla-central.

Note You need to log in before you can comment on or make changes to this bug.