Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Cached dynamic overlays still get saved to fastload (startup cache)

RESOLVED FIXED

Status

()

Core
XUL
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

({assertion})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.11 KB, patch
Neil Deakin (not available until Aug 9)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
When loading cached XUL dynamic overlays the document gets saved to the startup cache even though it had been already put in the startup cache when the overlay was originally cached.

Steps to reproduce problem:
1. Open a XUL document that uses dynamic overlays
2. Close and reopen the document

Expected result: Startup cache written once

Actual result: Startup cache written twice

Additional information:
###!!! ASSERTION: Existing entry in StartupCache.: 'entry == nsnull', file startupcache/StartupCache.cpp, line 298

Presumably the old fastload cache didn't do the check.
(Assignee)

Comment 1

6 years ago
Created attachment 549356 [details] [diff] [review]
Proposed patch

We should only set mIsFastLoad if we're actually doing a load. We already do this correctly in the two places where we trigger loads (later on in this method and also in StartDocumentLoad). So the code snippet is bogus.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #549356 - Flags: review?(enndeakin)
Attachment #549356 - Flags: review?(enndeakin) → review+
(Assignee)

Comment 2

6 years ago
Pushed changeset ed772265d2bc to mozilla-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.