Closed Bug 675215 Opened 10 years ago Closed 10 years ago

CTRL+dragging tab into the bookmarks should get bookmark's title from page title, not the file name

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 8

People

(Reporter: sidrabbit, Assigned: fryn)

References

Details

(Keywords: verified-beta, Whiteboard: [testday-20110930])

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:8.0a1) Gecko/20110729 Firefox/8.0a1
Build ID: 20110729030824

Steps to reproduce:

1. Open http://www.mozilla.com/en-US/firefox/all.html in a tab.
2. Press and hold CTRL, then drag this tab anywhere into bookmarks.


Actual results:

A new bookmark is created with a title "all.html" (from webpage file name).


Expected results:

New bookmark's title should be "Firefox web browser…etc" (from webpage title), as it was before new CTRL+drag bookmarking was implemented.
Blocks: 674732
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: nobody → fryn
Status: NEW → ASSIGNED
OS: Windows 7 → All
Hardware: x86 → All
Attached patch patch (obsolete) — Splinter Review
Attachment #549470 - Flags: review?(dao)
Comment on attachment 549470 [details] [diff] [review]
patch

Better to use browser.contentTitle, since tab.label can contain other cruft.
Also, can you do whatever it takes to fix creating a link on the desktop or in a file manager? I guess the text/html flavor does this. See also gIdentityHandler.onDragStart.
Attachment #549470 - Flags: review?(dao) → review-
Attached patch patch v2Splinter Review
(In reply to comment #2)
> Also, can you do whatever it takes to fix creating a link on the desktop or
> in a file manager? I guess the text/html flavor does this.

No, text/x-moz-url does this too. I tested dragging to the desktop and Windows Explorer on Windows and to the desktop and Finder on OS X.
Pinning a titled shortcut to the start menu on Windows 7 only works in IE9 though, because they use their proprietary .website-extension-associated type. I'm not sure what the mime type for that is.
Attachment #549470 - Attachment is obsolete: true
Attachment #549501 - Flags: review?(dao)
Is there a reason why one would use this.tabbrowser.getBrowserForTab(tab) instead of tab.linkedBrowser? AFAICT, the former simply returns the latter.
Oh, we currently can't handle those IE9 shortcuts anyway, so until we fix bug 605222 and bug 624070, it doesn't make sense to include that type.
Attachment #549501 - Flags: review?(dao) → review+
Pushed to fx-team. Will flip status when merged to m-c.
https://hg.mozilla.org/integration/fx-team/rev/d5c5b7841f21
http://hg.mozilla.org/mozilla-central/rev/d5c5b7841f21
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
Verified using Mozilla/5.0 (Windows NT 6.1; rv:8.0) Gecko/20100101 Firefox/8.0
Status: RESOLVED → VERIFIED
Keywords: verified-beta
Whiteboard: [testday-20110930]
You need to log in before you can comment on or make changes to this bug.