The default bug view has changed. See this FAQ.

CTRL+dragging tab into the bookmarks should get bookmark's title from page title, not the file name

VERIFIED FIXED in Firefox 8

Status

()

Firefox
Tabbed Browser
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: Sid, Assigned: fryn)

Tracking

({verified-beta})

Trunk
Firefox 8
verified-beta
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [testday-20110930])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:8.0a1) Gecko/20110729 Firefox/8.0a1
Build ID: 20110729030824

Steps to reproduce:

1. Open http://www.mozilla.com/en-US/firefox/all.html in a tab.
2. Press and hold CTRL, then drag this tab anywhere into bookmarks.


Actual results:

A new bookmark is created with a title "all.html" (from webpage file name).


Expected results:

New bookmark's title should be "Firefox web browser…etc" (from webpage title), as it was before new CTRL+drag bookmarking was implemented.
(Reporter)

Updated

6 years ago
Blocks: 674732

Updated

6 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Updated

6 years ago
Assignee: nobody → fryn
Status: NEW → ASSIGNED
OS: Windows 7 → All
Hardware: x86 → All
(Assignee)

Comment 1

6 years ago
Created attachment 549470 [details] [diff] [review]
patch
Attachment #549470 - Flags: review?(dao)
Comment on attachment 549470 [details] [diff] [review]
patch

Better to use browser.contentTitle, since tab.label can contain other cruft.
Also, can you do whatever it takes to fix creating a link on the desktop or in a file manager? I guess the text/html flavor does this. See also gIdentityHandler.onDragStart.
Attachment #549470 - Flags: review?(dao) → review-
(Assignee)

Comment 3

6 years ago
Created attachment 549501 [details] [diff] [review]
patch v2

(In reply to comment #2)
> Also, can you do whatever it takes to fix creating a link on the desktop or
> in a file manager? I guess the text/html flavor does this.

No, text/x-moz-url does this too. I tested dragging to the desktop and Windows Explorer on Windows and to the desktop and Finder on OS X.
Pinning a titled shortcut to the start menu on Windows 7 only works in IE9 though, because they use their proprietary .website-extension-associated type. I'm not sure what the mime type for that is.
Attachment #549470 - Attachment is obsolete: true
Attachment #549501 - Flags: review?(dao)
(Assignee)

Comment 4

6 years ago
Is there a reason why one would use this.tabbrowser.getBrowserForTab(tab) instead of tab.linkedBrowser? AFAICT, the former simply returns the latter.
(Assignee)

Comment 5

6 years ago
Oh, we currently can't handle those IE9 shortcuts anyway, so until we fix bug 605222 and bug 624070, it doesn't make sense to include that type.

Updated

6 years ago
Attachment #549501 - Flags: review?(dao) → review+
(Assignee)

Comment 6

6 years ago
Pushed to fx-team. Will flip status when merged to m-c.
https://hg.mozilla.org/integration/fx-team/rev/d5c5b7841f21
http://hg.mozilla.org/mozilla-central/rev/d5c5b7841f21
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8

Comment 8

6 years ago
Verified using Mozilla/5.0 (Windows NT 6.1; rv:8.0) Gecko/20100101 Firefox/8.0
Status: RESOLVED → VERIFIED
Keywords: verified-beta
Whiteboard: [testday-20110930]
You need to log in before you can comment on or make changes to this bug.