Closed Bug 675244 Opened 13 years ago Closed 13 years ago

IonMonkey: copy instructions are not removed from phi nodes.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: rpearl, Assigned: rpearl)

Details

Attachments

(2 files)

Although we do copy propagation during type analysis, we do not iterate over phi nodes to do so, so phi(copy, ...) does not get copy-propagated.
Attached patch patch v0, part 1Splinter Review
Part 1 adds removeDefAt to MDefinitionIterator
Attachment #549411 - Flags: review?(dvander)
Attached patch patch v0, part 2Splinter Review
part 2 uses the new functionality to replace the copy propagation with an MDefinitionIterator, rather than an MInstructionIterator.
Attachment #549412 - Flags: review?(dvander)
Attachment #549411 - Flags: review?(dvander) → review+
Comment on attachment 549412 [details] [diff] [review]
patch v0, part 2

Review of attachment 549412 [details] [diff] [review]:
-----------------------------------------------------------------

The first pass of this algorithm explicitly ignores phis
Attachment #549412 - Flags: review?(dvander) → review+
Oops. For part 1, I included the changes to use removeDefAt in value numbering. I'll split that off into a patch for bug 671430.

http://hg.mozilla.org/projects/ionmonkey/rev/c17b86bf406b
http://hg.mozilla.org/projects/ionmonkey/rev/e4273fa55bca
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.