Closed
Bug 675244
Opened 14 years ago
Closed 14 years ago
IonMonkey: copy instructions are not removed from phi nodes.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: rpearl, Assigned: rpearl)
Details
Attachments
(2 files)
|
4.03 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
|
1.07 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
Although we do copy propagation during type analysis, we do not iterate over phi nodes to do so, so phi(copy, ...) does not get copy-propagated.
|
Assignee | |
Comment 1•14 years ago
|
||
Part 1 adds removeDefAt to MDefinitionIterator
Attachment #549411 -
Flags: review?(dvander)
|
|
Assignee | |
Comment 2•14 years ago
|
||
part 2 uses the new functionality to replace the copy propagation with an MDefinitionIterator, rather than an MInstructionIterator.
Attachment #549412 -
Flags: review?(dvander)
|
||
Updated•14 years ago
|
Attachment #549411 -
Flags: review?(dvander) → review+
Comment on attachment 549412 [details] [diff] [review]
patch v0, part 2
Review of attachment 549412 [details] [diff] [review]:
-----------------------------------------------------------------
The first pass of this algorithm explicitly ignores phis
Attachment #549412 -
Flags: review?(dvander) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Oops. For part 1, I included the changes to use removeDefAt in value numbering. I'll split that off into a patch for bug 671430.
http://hg.mozilla.org/projects/ionmonkey/rev/c17b86bf406b
http://hg.mozilla.org/projects/ionmonkey/rev/e4273fa55bca
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•