Closed
Bug 675255
Opened 14 years ago
Closed 14 years ago
Port part 2 of |Bug 669913 - Viewing Sync quota blocks the entire Options window|
Categories
(SeaMonkey :: Sync UI, defect)
SeaMonkey
Sync UI
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.5
People
(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)
Details
Attachments
(1 file, 1 obsolete file)
|
3.31 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
Error Console output when opening the Quota dialog until this is fixed:
Weave.Service.getCollectionUsage is not a function
Weave.Service.getQuota is not a function
Attachment #549417 -
Flags: review?(neil)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 549417 [details] [diff] [review]
patch
>+ onCancel: function onCancel() {
This needs to be an unload handler (so that you don't have to explicitly run it when the window closes for whatever reason). r=me with that fixed.
>- ondialogcancel="return true;"
Bah, did I really review that? Totally unnecessary :-(
Attachment #549417 -
Flags: review?(neil) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
Too many subtle changes for my taste, thus re-requesting review just to be sure.
Attachment #549417 -
Attachment is obsolete: true
Attachment #549490 -
Flags: review?(neil)
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 549490 [details] [diff] [review]
patch v1a [Checkin: comment 4]
Interdiff looks nice and clean, don't know what you mean by too many changes...
Attachment #549490 -
Flags: review?(neil) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Comment on attachment 549490 [details] [diff] [review]
patch v1a [Checkin: comment 4]
http://hg.mozilla.org/comm-central/rev/cfb57e11ca39
Attachment #549490 -
Attachment description: patch v1a → patch v1a [Checkin: comment 4]
|
|
Assignee | |
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.5
You need to log in
before you can comment on or make changes to this bug.
Description
•