get rid of unnecessary calls to nsNPAPIPluginInstance::Start()

RESOLVED FIXED

Status

()

Core
Plug-ins
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Josh Aas, Assigned: Josh Aas)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 549458 [details] [diff] [review]
fix v1.0

nsNPAPIPluginInstance::Start is called in the [Try]SetUpPluginInstance code paths but we call it again if that succeeds. The second time it just bails at the start because the plugin is already started. There is one legitimate use case, or at least a case in which we can't simply remove the call, so that has been left.
Attachment #549458 - Flags: review?(jst)

Updated

6 years ago
Attachment #549458 - Flags: review?(jst) → review+
(Assignee)

Comment 1

6 years ago
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/f21f3fafab5b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.