Closed Bug 675309 Opened 10 years ago Closed 10 years ago

get rid of unnecessary calls to nsNPAPIPluginInstance::Start()

Categories

(Core :: Plug-ins, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

Details

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
nsNPAPIPluginInstance::Start is called in the [Try]SetUpPluginInstance code paths but we call it again if that succeeds. The second time it just bails at the start because the plugin is already started. There is one legitimate use case, or at least a case in which we can't simply remove the call, so that has been left.
Attachment #549458 - Flags: review?(jst)
Attachment #549458 - Flags: review?(jst) → review+
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/f21f3fafab5b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.