toolbar buttons show hover effect when dragging a tab

RESOLVED INVALID

Status

()

--
trivial
RESOLVED INVALID
7 years ago
6 years ago

People

(Reporter: masayuki, Unassigned)

Tracking

(Depends on: 1 bug)

Trunk
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

STR#1 (tabs on top):
1. Mousedown on a tab.
2. Move mouse cursor on Firefox button.

Actual Result:
The firefox button shows hover effect.

STR#2 (not tabs on top and shows bookmark toolbar):
1. Mousedown on a tab
2. Move mouse cursor on a folder in bookmark toolbar.

Actual Result:
The folder shows hover effect, but the tab cannot be dropped in the folder.

I don't think the STR#1 case makes users confuse. However, STR#2 isn't so.

It looks like the tab can be treated as a bookmark item, but actually not so.

And I see the hover effect on other buttons too. E.g., the other kink of tabs (e.g., when you drag a normal tab, app tabs) show hover effect. The add tab button, some added buttons by customizing in bookmark toolbar are too.

Comment 1

7 years ago
We already mitigated this problem by not having the bookmarks folder open on dragover (see https://bug455694.bugzilla.mozilla.org/attachment.cgi?id=528816) and clearly showing that the tab is directly manipulated rather than creating a copy of it that can be dropped into folders.

I don't think it's worth the effort to fix this minor issue.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WONTFIX
Frank, don't you misunderstand my report? I think that we should prevent the hover effect, I don't think that the tab should act as a bookmark item.
Yeah, this bug isn't really about bookmark folders. (And comment 0 doesn't make much sense in this regard either when it talks about bookmark items.)

Bug 674925 should fix this. Real drag and drop prevents hover effects while dragging.
Severity: normal → trivial
Status: RESOLVED → REOPENED
Component: Toolbars → Tabbed Browser
Depends on: 674925
QA Contact: toolbars → tabbed.browser
Resolution: WONTFIX → ---

Comment 4

6 years ago
Patch in bug 455694 was backed out.
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.