675431 - Duplicate accesskey in Messenger's Tools menu

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: General, defect)

Description

[Karsten Düsterloh]

In the Tools menu of the Messenger main window, both "_S_earch Addresses" and "_S_et up Sync" use the same accesskey 'S'.

Caused by <http://hg.mozilla.org/comm-central/rev/5547e7013edb>, afaict.

Comment 1

[Karsten Düsterloh]

As IanN points out, 'M' is also used twice: "Search _M_essages" and "Data _M_anager". :-/

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

"c" can be used (bound to Cookie Manager in the browser, but unused elsewhere) for "Search Addresses".

"M" could be used for "Search Messages" if "D" was used for "Data Manager" and "n" for "Download Manager".

Comment 3

[Edmund Wong (:ewong)]

Attachment: Changed accesskeys in Messenger's tools menu to avoid duplication.

Comment 4

[Ian Neal]

Comment on attachment 580588 [details] [diff] [review]
Changed accesskeys in Messenger's tools menu to avoid duplication.

Whilst we are here there is also "Search the Web" conflicting with Sync too.
http://mxr.mozilla.org/comm-central/source/suite/locales/en-US/chrome/browser/navigatorOverlay.dtd#86
I would suggest using "b" for that.

The other option would be to change Sync to use "n", change "Search Messages" to "c" and then none of the other changes would be needed.

I am happy either way.

Comment 5

[Edmund Wong (:ewong)]

Attachment: Changed accesskeys in Messenger's and Navigator's tools menu to avoid duplication. (v2)

Comment 6

[Edmund Wong (:ewong)]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/69926c6f425c