Misuse of PRBool found by use of ++ or -- operators

RESOLVED FIXED in mozilla8

Status

()

Core
Rewriting and Analysis
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mwu, Assigned: mwu)

Tracking

(Depends on: 1 bug)

Trunk
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 549627 [details] [diff] [review]
Fix

This was a recent addition to the boolcheck so it didn't get fixed with the other bugs. When code does ++ or -- to a PRBool, it usually isn't using it as a PRBool. Fortunately there aren't too many cases of this.

Reviewers:

jst:
 dom/src/storage/nsDOMStorage.cpp        |    2 +-

roc:
 layout/generic/nsBlockReflowContext.cpp |    2 +-
Attachment #549627 - Flags: review?(roc)
Attachment #549627 - Flags: review?(jst)
Attachment #549627 - Flags: review?(roc) → review+

Updated

6 years ago
Attachment #549627 - Flags: review?(jst) → review+
(Assignee)

Comment 1

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/a4b682211c3a
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/a4b682211c3a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.