Closed
Bug 675482
Opened 14 years ago
Closed 14 years ago
Misuse of PRBool found by use of ++ or -- operators
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Developer Infrastructure
Source Code Analysis
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla8
People
(Reporter: mwu, Assigned: mwu)
References
Details
(Whiteboard: [inbound])
Attachments
(1 file)
|
1.13 KB,
patch
|
jst
:
review+
roc
:
review+
|
Details | Diff | Splinter Review |
This was a recent addition to the boolcheck so it didn't get fixed with the other bugs. When code does ++ or -- to a PRBool, it usually isn't using it as a PRBool. Fortunately there aren't too many cases of this.
Reviewers:
jst:
dom/src/storage/nsDOMStorage.cpp | 2 +-
roc:
layout/generic/nsBlockReflowContext.cpp | 2 +-
Attachment #549627 -
Flags: review?(roc)
Attachment #549627 -
Flags: review?(jst)
Attachment #549627 -
Flags: review?(roc) → review+
|
||
Updated•14 years ago
|
Attachment #549627 -
Flags: review?(jst) → review+
|
Assignee | |
Comment 1•14 years ago
|
||
Whiteboard: [inbound]
|
||
Comment 2•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•