Last Comment Bug 675482 - Misuse of PRBool found by use of ++ or -- operators
: Misuse of PRBool found by use of ++ or -- operators
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: Rewriting and Analysis (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla8
Assigned To: Michael Wu [:mwu]
:
Mentors:
Depends on: 669808
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-30 23:24 PDT by Michael Wu [:mwu]
Modified: 2011-08-02 03:43 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix (1.13 KB, patch)
2011-07-30 23:24 PDT, Michael Wu [:mwu]
jst: review+
roc: review+
Details | Diff | Splinter Review

Description Michael Wu [:mwu] 2011-07-30 23:24:32 PDT
Created attachment 549627 [details] [diff] [review]
Fix

This was a recent addition to the boolcheck so it didn't get fixed with the other bugs. When code does ++ or -- to a PRBool, it usually isn't using it as a PRBool. Fortunately there aren't too many cases of this.

Reviewers:

jst:
 dom/src/storage/nsDOMStorage.cpp        |    2 +-

roc:
 layout/generic/nsBlockReflowContext.cpp |    2 +-
Comment 2 Marco Bonardo [::mak] 2011-08-02 03:43:44 PDT
http://hg.mozilla.org/mozilla-central/rev/a4b682211c3a

Note You need to log in before you can comment on or make changes to this bug.