The default bug view has changed. See this FAQ.

Crash during startup on ARM when linked with recent GNU ld

RESOLVED FIXED in mozilla8

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Other Branch
mozilla8
ARM
Linux
Points:
---

Firefox Tracking Flags

(firefox7 affected)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Thanks to this GNU ld bug: http://sourceware.org/bugzilla/show_bug.cgi?id=13049 , building with a recent GNU ld (>= 2.21.1 are affected for sure, not sure about older ones ; 2.19 is definitely not affected) on ARM leads to a crash.
(Assignee)

Comment 1

6 years ago
Created attachment 549783 [details] [diff] [review]
Work around recent ARM GNU ld bug with -fdata-sections and variables names starting with "stub" leading to crash

A workaround is to avoid using variables with a name starting with "stub".

js/src/jsdhash.cpp has the same variable name, but as it is compiled as C++, its name is mangled and thus doesn't start with "stub".
Attachment #549783 - Flags: review?(benjamin)
Can we use gold for this?
(Assignee)

Comment 3

6 years ago
(In reply to comment #2)
> Can we use gold for this?

It's not only a problem for us. It's a problem for those that use GNU ld on ARM.
(Assignee)

Updated

6 years ago
Assignee: nobody → mh+mozilla
Comment on attachment 549783 [details] [diff] [review]
Work around recent ARM GNU ld bug with -fdata-sections and variables names starting with "stub" leading to crash

Since pldhash is jsdhash, can we just compile it as C++ and move on?
(Assignee)

Comment 5

6 years ago
Created attachment 551473 [details] [diff] [review]
Compile pldhash as C++

> Since pldhash is jsdhash, can we just compile it as C++ and move on?

We can.
Attachment #551473 - Flags: review?(benjamin)
(Assignee)

Updated

6 years ago
Attachment #549783 - Attachment is obsolete: true
Attachment #549783 - Flags: review?(benjamin)
Attachment #551473 - Flags: review?(benjamin) → review+
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/3d20269baeee
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/3d20269baeee
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
For the record, this requires a clobber to build successfully, or else you'll get errors like:
> make[8]: *** No rule to make target `pldhash.c', needed by `pldhash.o'.  Stop.

(noting here in case any devs / projec-branch-owners encounter this error and do a bugzilla search to see if it's reported anywhere)
(Assignee)

Updated

6 years ago
Status: RESOLVED → REOPENED
status-firefox7: --- → affected
Resolution: FIXED → ---
Version: Trunk → Other Branch
(Assignee)

Updated

6 years ago
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED

Updated

6 years ago

Updated

6 years ago
You need to log in before you can comment on or make changes to this bug.