Note: There are a few cases of duplicates in user autocompletion which are being worked on.

nsICertVerificationListener should be called on the main thread

RESOLVED FIXED in mozilla10

Status

()

Core
Security: PSM
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: bsmedberg, Assigned: bsmedberg)

Tracking

(Depends on: 1 bug)

Trunk
mozilla10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
viewCertDetails.js currently uses an XPCOM proxy because nsICertVerificationListener::notify is called on the cert verification thread. This is kinda silly: the only caller needs the callback on the main thread, and we should make the API do the right thing. This is also useful for getting rid of XPCOM proxies.
(Assignee)

Comment 1

6 years ago
Created attachment 549884 [details] [diff] [review]
Call nsICertVerificationListener on the main thread, rev. 1
Attachment #549884 - Flags: review?(honzab.moz)
Comment on attachment 549884 [details] [diff] [review]
Call nsICertVerificationListener on the main thread, rev. 1

Review of attachment 549884 [details] [diff] [review]:
-----------------------------------------------------------------

r=bsmith
Attachment #549884 - Flags: review+
Comment on attachment 549884 [details] [diff] [review]
Call nsICertVerificationListener on the main thread, rev. 1

Review of attachment 549884 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab
Attachment #549884 - Flags: review?(honzab.moz) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec560107b01d
OS: Linux → All
Hardware: x86_64 → All
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/ec560107b01d
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]

Updated

4 years ago
Depends on: 936407
You need to log in before you can comment on or make changes to this bug.