Last Comment Bug 675702 - nsICertVerificationListener should be called on the main thread
: nsICertVerificationListener should be called on the main thread
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Security: PSM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla10
Assigned To: Benjamin Smedberg [:bsmedberg]
:
Mentors:
Depends on: 936407
Blocks: 675221
  Show dependency treegraph
 
Reported: 2011-08-01 12:07 PDT by Benjamin Smedberg [:bsmedberg]
Modified: 2013-11-08 10:18 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Call nsICertVerificationListener on the main thread, rev. 1 (5.15 KB, patch)
2011-08-01 12:13 PDT, Benjamin Smedberg [:bsmedberg]
honzab.moz: review+
brian: review+
Details | Diff | Splinter Review

Description Benjamin Smedberg [:bsmedberg] 2011-08-01 12:07:57 PDT
viewCertDetails.js currently uses an XPCOM proxy because nsICertVerificationListener::notify is called on the cert verification thread. This is kinda silly: the only caller needs the callback on the main thread, and we should make the API do the right thing. This is also useful for getting rid of XPCOM proxies.
Comment 1 Benjamin Smedberg [:bsmedberg] 2011-08-01 12:13:10 PDT
Created attachment 549884 [details] [diff] [review]
Call nsICertVerificationListener on the main thread, rev. 1
Comment 2 Brian Smith (:briansmith, :bsmith, use NEEDINFO?) 2011-10-31 01:08:37 PDT
Comment on attachment 549884 [details] [diff] [review]
Call nsICertVerificationListener on the main thread, rev. 1

Review of attachment 549884 [details] [diff] [review]:
-----------------------------------------------------------------

r=bsmith
Comment 3 Honza Bambas (:mayhemer) 2011-11-01 12:47:33 PDT
Comment on attachment 549884 [details] [diff] [review]
Call nsICertVerificationListener on the main thread, rev. 1

Review of attachment 549884 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab
Comment 4 Brian Smith (:briansmith, :bsmith, use NEEDINFO?) 2011-11-02 21:22:30 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec560107b01d
Comment 5 Marco Bonardo [::mak] 2011-11-03 08:57:51 PDT
https://hg.mozilla.org/mozilla-central/rev/ec560107b01d

Note You need to log in before you can comment on or make changes to this bug.