Closed Bug 675702 Opened 9 years ago Closed 8 years ago

nsICertVerificationListener should be called on the main thread

Categories

(Core :: Security: PSM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: benjamin, Assigned: benjamin)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

viewCertDetails.js currently uses an XPCOM proxy because nsICertVerificationListener::notify is called on the cert verification thread. This is kinda silly: the only caller needs the callback on the main thread, and we should make the API do the right thing. This is also useful for getting rid of XPCOM proxies.
Comment on attachment 549884 [details] [diff] [review]
Call nsICertVerificationListener on the main thread, rev. 1

Review of attachment 549884 [details] [diff] [review]:
-----------------------------------------------------------------

r=bsmith
Attachment #549884 - Flags: review+
Comment on attachment 549884 [details] [diff] [review]
Call nsICertVerificationListener on the main thread, rev. 1

Review of attachment 549884 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab
Attachment #549884 - Flags: review?(honzab.moz) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec560107b01d
OS: Linux → All
Hardware: x86_64 → All
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/ec560107b01d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Depends on: 936407
You need to log in before you can comment on or make changes to this bug.