675877 - Remove the top border of #unifinder-searchBox

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Richard Marti (:Paenglab)]

The #unifinder-searchBox has a border-top: 1px solid ThreeDHighlight; but the #task-addition-box not.

Under Win7 and Linux it looks better without this border. Then the box has a soft changeover to the tabs. Under XP and Mac it adds a slightly non viewable border under the dark default tab bar border.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Remove the border

Decathlon is it okay to ask you for review? I think Fallen has a lot to do with other bugs.

Comment 2

[Decathlon]

(In reply to Richard Marti [:paenglab] from comment #1)

> Decathlon is it okay to ask you for review? I think Fallen has a lot to do
> with other bugs.

Sure, if Philipp agrees and if you are not in a hurry :-)

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

(In reply to Decathlon from comment #2)
> (In reply to Richard Marti [:paenglab] from comment #1)
> 
> > Decathlon is it okay to ask you for review? I think Fallen has a lot to do
> > with other bugs.
> 
> Sure, if Philipp agrees and if you are not in a hurry :-)

Any time! I see the both of you as good reviewers so if there's any UI patches, feel free to ask each other for review, now and in the future.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Remove the border

Now also for the gnomestripe theme

Comment 5

[Decathlon]

Comment on attachment 553902 [details] [diff] [review]
Remove the border

I think that border is useful with the Windows Classic theme, also to give the same look of the mail panel in Thunderbird (see next screeshot). Maybe for this reason, the border should be added to the #task-addition-box too.

But I think that Windows Classic theme should be the minor issue compared with Linux, Mac, Win(XP-Vista-7) with other themes.
At the moment I can test only on Win7 and without the border I see the look is better. If you say that it looks better on Linux, XP and Mac as well, let's delete the border.

r+

Comment 6

[Decathlon]

Attachment: Border on Window Classic theme

Comment 7

[Richard Marti (:Paenglab)]

I could add a border for classic only with a :-moz-system-metric(windows-classic) selector.

On Mac it's only a subtle highlight border under the black border.

Tomorrow I'll add a screenshot under XP.

Comment 8

[Richard Marti (:Paenglab)]

Attachment: Look under Linux without border

Without border the active tabs are looking more "connected" to the content now also for the calendar.

Comment 9

[Decathlon]

No need of a screenshot for XP, I think removing the border is fine :-)

Comment 10

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/dc7976fab4f3>
-> FIXED

Comment 11

[Philipp Kewisch [:Fallen][📱📆]]

Backported to comm-aurora <http://hg.mozilla.org/releases/comm-aurora/rev/b215a1058a32>

Comment 12

[Philipp Kewisch [:Fallen][📱📆]]

Backported to comm-beta <http://hg.mozilla.org/releases/comm-beta/rev/1dcf60c84977>