Closed Bug 675877 Opened 9 years ago Closed 9 years ago

Remove the top border of #unifinder-searchBox

Categories

(Calendar :: General, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(3 files, 1 obsolete file)

The #unifinder-searchBox has a border-top: 1px solid ThreeDHighlight; but the #task-addition-box not.

Under Win7 and Linux it looks better without this border. Then the box has a soft changeover to the tabs. Under XP and Mac it adds a slightly non viewable border under the dark default tab bar border.
Attached patch Remove the border (obsolete) β€” β€” Splinter Review
Decathlon is it okay to ask you for review? I think Fallen has a lot to do with other bugs.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #550023 - Flags: review?(bv1578)
(In reply to Richard Marti [:paenglab] from comment #1)

> Decathlon is it okay to ask you for review? I think Fallen has a lot to do
> with other bugs.

Sure, if Philipp agrees and if you are not in a hurry :-)
(In reply to Decathlon from comment #2)
> (In reply to Richard Marti [:paenglab] from comment #1)
> 
> > Decathlon is it okay to ask you for review? I think Fallen has a lot to do
> > with other bugs.
> 
> Sure, if Philipp agrees and if you are not in a hurry :-)

Any time! I see the both of you as good reviewers so if there's any UI patches, feel free to ask each other for review, now and in the future.
Attached patch Remove the border β€” β€” Splinter Review
Now also for the gnomestripe theme
Attachment #550023 - Attachment is obsolete: true
Attachment #550023 - Flags: review?(bv1578)
Attachment #553902 - Flags: review?(bv1578)
Comment on attachment 553902 [details] [diff] [review]
Remove the border

I think that border is useful with the Windows Classic theme, also to give the same look of the mail panel in Thunderbird (see next screeshot). Maybe for this reason, the border should be added to the #task-addition-box too.

But I think that Windows Classic theme should be the minor issue compared with Linux, Mac, Win(XP-Vista-7) with other themes.
At the moment I can test only on Win7 and without the border I see the look is better. If you say that it looks better on Linux, XP and Mac as well, let's delete the border.

r+
Attachment #553902 - Flags: review?(bv1578) → review+
I could add a border for classic only with a :-moz-system-metric(windows-classic) selector.

On Mac it's only a subtle highlight border under the black border.

Tomorrow I'll add a screenshot under XP.
Without border the active tabs are looking more "connected" to the content now also for the calendar.
No need of a screenshot for XP, I think removing the border is fine :-)
Keywords: checkin-needed
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/dc7976fab4f3>
-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Trunk
Backported to comm-aurora <http://hg.mozilla.org/releases/comm-aurora/rev/b215a1058a32>
Target Milestone: Trunk → 1.0b6
You need to log in before you can comment on or make changes to this bug.