675899 - HTML5 video player should show controls when video ends (if controls attribute is present)

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, enhancement)

Description

[Michał]

Currently, when Video in WebM format ends, there is no "notification" that it has ended. It would be great, if for example video screen on end become covered by black transparent frame (like when the video is loading).

Comment 1

[Matthias Versen [:Matti]]

It could offer to play the video again....

Comment 2

[Justin Dolske [:Dolske]]

We should probably, at a minimum, redisplay the controls. Then you can see that (1) something happened and (2) it's at the end.

YouTube et al show extra stuff at the end, but we obviously don't have anything similar. I suppose we could show like a big "rewind" icon or something, but maybe just showing the controls is enough?

Comment 3

[Paul Adenot (:padenot)]

Attachment: Patch v0 -- Show controls when a video ends.

Here is a patch that simply show the controls when a video ends.

Comment 4

[Justin Dolske [:Dolske]]

Comment on attachment 551075 [details] [diff] [review]
Patch v0 -- Show controls when a video ends.

r+ with leaving the call to setupStatusFader() (just add the startFadeIn() call)... I _think_ there can be cases where setupStatusFader() here would be removing a throbber overlay... It should be harmless in any case.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Addressed review comments. Pushed to fx-team:
https://hg.mozilla.org/integration/fx-team/rev/0c3d5e7ce23c

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/0c3d5e7ce23c

Comment 7

[Mihaela Velimiroviciu (:mihaelav)]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (Windows NT 6.1; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (X11; Linux i686; rv:10.0) Gecko/20100101 Firefox/10.0

Verified the fix on the above builds: the controls bar is displayed when video ends if controls are enabled, but if controls are hidden, there is no "notification" that the video finished (nothing happens; controls are not displayed). Also, if video is played in full screen, it automatically exits full screen when it finishes playing. Is this intended?

Comment 8

[Mihaela Velimiroviciu (:mihaelav)]

(In reply to Mihaela Velimiroviciu [QA] from comment #7)
> Also, if video is played in full screen, it automatically exits
> full screen when it finishes playing. Is this intended?

Mozilla/5.0 (Windows NT 6.1; rv:10.0) Gecko/20100101 Firefox/10.0 beta 6
Mozilla/5.0 (Windows NT 6.1; rv:11.0a2) Gecko/20120125 Firefox/11.0a2
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0a2) Gecko/20120125 Firefox/11.0a2
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (X11; Linux i686; rv:10.0) Gecko/20100101 Firefox/10.0

Verified again with the latest beta (10beta 6) and Aurora and I could not reproduce this. 
Marking as VERIIFED