676049 - Using MozURL implementations for certain nsLocation APIs to reduce code duplication

Status: RESOLVED INCOMPLETE

(Core :: DOM: Core & HTML, defect)

Description

[Shawn Gong]

The newly implemented MozURL (bug# 668680) share certain features with nsLocation, but is a more standalone class. As a result, nsLocation should use MozURL's implementations for those features.

Comment 1

[Shawn Gong]

Attachment: Patch 1. Using MozURL code in nsLocation when available.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 550520 [details] [diff] [review]
Patch 1. Using MozURL code in nsLocation when available.

Punting this over to Ehsan since you are reviewing the URL API.

This stuff was written on request from bz, so feel free to ask him about how big the need for this stuff is.

Comment 3

[(no longer active)]

Comment on attachment 550520 [details] [diff] [review]
Patch 1. Using MozURL code in nsLocation when available.

Review of attachment 550520 [details] [diff] [review]:
-----------------------------------------------------------------

What tree is this patch against?  We decided to implement the URL spec instead of this in bug 887364.  That work is now waiting for review, but if you want to work on this stuff right now, you can import those patches and use the dom/base/URL.h API here.

Comment 4

[Valentin Gosu [:valentin] (he/him)]

I don't think this bug is applicable anymore.