Closed
Bug 676202
Opened 13 years ago
Closed 13 years ago
GCLI should use 2 space indents not 4
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jwalker, Assigned: jwalker)
Details
(Whiteboard: [minotaur][best:1d, likely:1d, worst:1d])
I know this is trivia, but for some time I've been wondering about changing GCLI to use 2 space indents rather than 4.
The benefits are:
- without this, moving code between Moz and GCLI will break diffs, and I suspect there's going to be quite a bit of this
- It's the most common in non-Moz style guides too - Ace/etc is in the minority here. I went through the top JS style guides (according to Google) and those that mention are more likely to say 2.
- less line wrapping with nested code
The drawbacks are:
- more code churn moving code between Ace and GCLI
- Lots of churn now
We're about to change the license header, which is significant churn, so now is the time to do it. I'm serious this time :)
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → jwalker
Whiteboard: [minotaur][best:1d, likely:1d, worst:1d]
Assignee | ||
Updated•13 years ago
|
Blocks: GCLI-FUTURE
Assignee | ||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•13 years ago
|
No longer blocks: GCLI-FUTURE
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•