Last Comment Bug 676202 - GCLI should use 2 space indents not 4
: GCLI should use 2 space indents not 4
[minotaur][best:1d, likely:1d, worst:1d]
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: unspecified
: All All
-- normal (vote)
: ---
Assigned To: Joe Walker [:jwalker] (needinfo me or ping on irc)
: J. Ryan Stinnett [:jryans] (use ni?)
Depends on:
  Show dependency treegraph
Reported: 2011-08-03 02:22 PDT by Joe Walker [:jwalker] (needinfo me or ping on irc)
Modified: 2012-01-13 10:37 PST (History)
0 users
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Description User image Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-08-03 02:22:26 PDT
I know this is trivia, but for some time I've been wondering about changing GCLI to use 2 space indents rather than 4.

The benefits are:
- without this, moving code between Moz and GCLI will break diffs, and I suspect there's going to be quite a bit of this
- It's the most common in non-Moz style guides too - Ace/etc is in the minority here. I went through the top JS style guides (according to Google) and those that mention are more likely to say 2.
- less line wrapping with nested code

The drawbacks are:
- more code churn moving code between Ace and GCLI
- Lots of churn now

We're about to change the license header, which is significant churn, so now is the time to do it. I'm serious this time :)

Note You need to log in before you can comment on or make changes to this bug.