Closed
Bug 676267
Opened 14 years ago
Closed 14 years ago
expose stale state on accessibles unattached from tree
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: surkov, Assigned: surkov)
References
(Blocks 1 open bug)
Details
(Keywords: access)
Attachments
(1 file)
5.74 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•14 years ago
|
||
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #550414 -
Flags: review?(trev.saunders)
Comment 2•14 years ago
|
||
Comment on attachment 550414 [details] [diff] [review]
patch
> */
>- inline bool HasAccessible(nsINode* aNode)
>+ inline bool HasAccessible(nsINode* aNode) const
> {
> return GetAccessible(aNode);
> }
nit, don't we usually use { return blah; } in cases like this?
>
> /**
>+ * Return true if the given accessible is in document.
>+ */
>+ inline bool IsInDocument(nsAccessible* aAccessible) const
>+ {
>+ nsAccessible* acc = aAccessible;
why do you need this local var? why not just mutate aAcc?
>+ while (acc && !acc->IsPrimaryForNode())
>+ acc = acc->Parent();
>+
>+ return acc ? !!mNodeToAccessibleMap.Get(acc->GetNode()) : false;
>+ }
why do you need !! does some compiler complain?
Attachment #550414 -
Flags: review?(trev.saunders) → review+
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #2)
> nit, don't we usually use { return blah; } in cases like this?
ok, fine with me
> >+ {
> >+ nsAccessible* acc = aAccessible;
>
> why do you need this local var? why not just mutate aAcc?
harder to debug, following the rule "keep in arguments unchanged"
> >+ return acc ? !!mNodeToAccessibleMap.Get(acc->GetNode()) : false;
> >+ }
>
> why do you need !! does some compiler complain?
I didn't try, just this is usual way to convert pointer to boolean
Assignee | ||
Comment 4•14 years ago
|
||
landed on inbound http://hg.mozilla.org/integration/mozilla-inbound/rev/dd38dafe931b
Flags: in-testsuite+
Whiteboard: [inbound]
Assignee | ||
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Assignee | ||
Updated•14 years ago
|
Whiteboard: [inbound]
You need to log in
before you can comment on or make changes to this bug.
Description
•