Last Comment Bug 676277 - onmessage event.origin handling in websockets is wrong
: onmessage event.origin handling in websockets is wrong
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: Networking: WebSockets (show other bugs)
: Trunk
: x86 All
: -- normal (vote)
: mozilla8
Assigned To: Patrick McManus [:mcmanus]
:
Mentors:
Depends on: 670687
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-03 09:27 PDT by Patrick McManus [:mcmanus]
Modified: 2013-12-27 14:30 PST (History)
11 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch 1 (6.17 KB, patch)
2011-08-03 09:40 PDT, Patrick McManus [:mcmanus]
jonas: review+
Details | Diff | Splinter Review

Description Patrick McManus [:mcmanus] 2011-08-03 09:27:12 PDT
+++ This bug was initially created as a clone of Bug #670687 +++

The origin property of the onmessage event has always been derived from the principal. According to https://bugzilla.mozilla.org/show_bug.cgi?id=670687#c24 we want to derive that from the ws[s]:// host.
Comment 1 Patrick McManus [:mcmanus] 2011-08-03 09:40:18 PDT
Created attachment 550408 [details] [diff] [review]
patch 1

change to derive origin from ws://, keeping it in utf-16.. with a test
Comment 2 Marco Bonardo [::mak] (Away 6-20 Aug) 2011-08-04 03:18:21 PDT
http://hg.mozilla.org/mozilla-central/rev/19b6ce39339e

Note You need to log in before you can comment on or make changes to this bug.