onmessage event.origin handling in websockets is wrong

RESOLVED FIXED in mozilla8

Status

()

Core
Networking: WebSockets
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: mcmanus, Assigned: mcmanus)

Tracking

Trunk
mozilla8
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
+++ This bug was initially created as a clone of Bug #670687 +++

The origin property of the onmessage event has always been derived from the principal. According to https://bugzilla.mozilla.org/show_bug.cgi?id=670687#c24 we want to derive that from the ws[s]:// host.
(Assignee)

Updated

6 years ago
Keywords: sec-review-needed
(Assignee)

Updated

6 years ago
status-firefox6: fixed → ---
status-firefox7: fixed → ---
tracking-firefox6: + → ---
tracking-firefox7: + → ---
(Assignee)

Comment 1

6 years ago
Created attachment 550408 [details] [diff] [review]
patch 1

change to derive origin from ws://, keeping it in utf-16.. with a test
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
Attachment #550408 - Flags: review?(jonas)
Attachment #550408 - Flags: review?(jonas) → review+
(Assignee)

Updated

6 years ago
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
http://hg.mozilla.org/mozilla-central/rev/19b6ce39339e
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.