676321 - Sidebar briefly shows up on orientation change while using form autocomplete

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

User Agent: Mozilla/5.0 (X11; Linux i686; rv:5.0) Gecko/20100101 Firefox/5.0
Build ID: 20110622105737

Steps to reproduce:

Steps to reproduce:

1. Focus on an HTML form entry that has autocomplete suggestions, make sure it has a few suggestions.
2. While the autocomplete popup is visible, change the device orientation from landscape to portrait.


Actual results:

The left sidebar briefly shows up and slides out.


Expected results:

The left sidebar should not be visible at any time when changing device orientation.

Comment 1

[Lucas Rocha (:lucasr)]

This seems to be caused by popup being a bit too wide and causing the left sidebar to show up when orientation changes. Taking.

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

I had 7 tabs open (causing more than 1 column of tabs to appear in the sidebar) in landscape, and then shifted to portrait.  The bottom portion of the form page was checkerboarded, and the tab was partially out.

This was at http://people.mozilla.com/~nhirata/html_tp/formsninput.html

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: Fixes in code comment

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: Remove redundant visibility update call

Comment 5

[Lucas Rocha (:lucasr)]

Attachment: Ensure size of popup doesn't overflow visible area on window resize

Comment 6

[Lucas Rocha (:lucasr)]

Attachment: Don't reset popup position, not necessary

Comment 7

[Lucas Rocha (:lucasr)]

Attachment: Small coding style fix

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Lucas, could you please provide patches whose commit message includes the bug number and "r=mbrubeck"? That would be really helpful.

Comment 9

[Lucas Rocha (:lucasr)]

Attachment: Bug 676321 - Fix the phrasing of explanatory comment on ContentPopupHelper's anchorTo()

Comment 10

[Lucas Rocha (:lucasr)]

Attachment: Bug 676321 - Small coding style fix in mobile's browser.js

Comment 11

[Lucas Rocha (:lucasr)]

Attachment: Bug 676321 - Remove redudant visibility update as anchorTo() does it too

Comment 12

[Lucas Rocha (:lucasr)]

Attachment: Bug 676321 - Do not reset popup position on content resize, panning, and zooming

Comment 13

[Lucas Rocha (:lucasr)]

Attachment: Bug 676321 - Sidebar briefly shows up on orientation change while using form autocomplete

Comment 14

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d103df4833c4
http://hg.mozilla.org/integration/mozilla-inbound/rev/bac63bffbc15
http://hg.mozilla.org/integration/mozilla-inbound/rev/38f76966da56
http://hg.mozilla.org/integration/mozilla-inbound/rev/aa378dbf52e7
http://hg.mozilla.org/integration/mozilla-inbound/rev/79399ce1a1fb

Thanks!

Comment 15

[Ed Morley [:emorley]]

http://hg.mozilla.org/mozilla-central/rev/d103df4833c4
http://hg.mozilla.org/mozilla-central/rev/bac63bffbc15
http://hg.mozilla.org/mozilla-central/rev/38f76966da56
http://hg.mozilla.org/mozilla-central/rev/aa378dbf52e7
http://hg.mozilla.org/mozilla-central/rev/79399ce1a1fb

Comment 16

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110927
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1