676340 - Crash [@ nsAccessible::NativeState() ] (called by nsXULTextFieldAccessible::GetValue)

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

similar to bug 649604 where nsHTMLTextFieldAccessible was a cause.

Reports: https://crash-stats.mozilla.com/report/list?product=Firefox&query_search=signature&query_type=contains&query=Accessible&reason_type=contains&date=08%2F03%2F2011%2011%3A29%3A56&range_value=4&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=nsAccessible%3A%3ANativeState%28%29

Comment 1

[Trevor Saunders (:tbsaunde)]

Comment on attachment 550454 [details] [diff] [review]
patch

SHOULDN'T YOU GET THE MSAA METHOD AS WELL AS THE XPCOM ONE? BUT i DON'T REALLY CARE SINCE i'LL ET IT SOON ANYWAY IF YOU DON'T

Comment 2

[alexander :surkov (:asurkov)]

(In reply to comment #1)
> Comment on attachment 550454 [details] [diff] [review] [diff] [details] [review]
> patch
> 
> SHOULDN'T YOU GET THE MSAA METHOD AS WELL AS THE XPCOM ONE? BUT i DON'T
> REALLY CARE SINCE i'LL ET IT SOON ANYWAY IF YOU DON'T

that would be safer, but not technically correct, and yes I wouldn't care much since it goes away.

Comment 3

[alexander :surkov (:asurkov)]

inbound land http://hg.mozilla.org/integration/mozilla-inbound/rev/f0075fe638ee

Comment 5

[alexander :surkov (:asurkov)]

landed http://hg.mozilla.org/mozilla-central/rev/f0075fe638ee

Comment 6

[Karel Jára]

Firefox 6 keeps crashing with this.

Comment 7

[alexander :surkov (:asurkov)]

Comment on attachment 550454 [details] [diff] [review]
patch

can we get it into Firefox 7? Trivial patch, no risk. High crash numbers in accessibility module.

Comment 8

[alexander :surkov (:asurkov)]

(In reply to Karel Jára from comment #6)
> Firefox 6 keeps crashing with this.

Firefox 6 was shipped, all we can do is to try to get it into Firefox 7.

Comment 9

[Karel Jára]

This should definitely be reopened or a new bug should be filed od this nsAccessible::NativeState() bug. Recently I hasn’t been able to retrieve my latest crash reports with FF 7 beta. But with FF 6 beta it often did after a download has been completed.

Comment 10

[[:Cww]]

(In reply to Karel Jára from comment #9)

This fix landed on the Nightly version of Firefox which is Firefox 8. The release drivers are currently debating whether to take this patch for Firefox 7.

Comment 11

[alexander :surkov (:asurkov)]

Marco, could you please land this patch on beta?

Comment 12

[Trevor Saunders (:tbsaunde)]

(In reply to alexander surkov from comment #11)
> Marco, could you please land this patch on beta?

Marco was on vacation this week, but I landed it as http://hg.mozilla.org/releases/mozilla-beta/rev/61d6b5f9ee9f

Comment 13

[David Bolter [:davidb] (NeedInfo me for attention)]

Excellent - thanks Trevor.

Comment 14

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #12)
> (In reply to alexander surkov from comment #11)
> > Marco, could you please land this patch on beta?
> 
> Marco was on vacation this week, but I landed it as
> http://hg.mozilla.org/releases/mozilla-beta/rev/61d6b5f9ee9f

yes, thank you for doing this!

Comment 15

[u279076]

qa- as no QA fix verification needed