676379 - Kuma: Mark a page in need of review as reviewed

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Editing, defect, P2)

Description

[Les Orchard [:lorchard]]

Capturing a feature request from sheppy:

"Once someone has reviewed the article, they should be able to hit a button to quickly flag it as reviewed for whichever type of review they performed."

This could be as simple as removing the review flag, but probably needs some audit logging in revisions about who & when

Comment 1

[Eric Shepherd [:sheppy]]

This would presumably be available in read mode as well as in edit mode, so they could mark off that an article's been reviewed whether they had to make any fixes or not.

Comment 2

[John Karahalis [:openjck]]

I think I understand this one pretty well, but there are still many unanswered questions. Can you please answer the following?

https://bugzilla-stage-tip.mozilla.org/show_bug.cgi?id=686894#c0

Comment 3

[Eric Shepherd [:sheppy]]

What problems would this solve?
===============================
Currently, to remove the review flag from an article, you have to open the editor. This takes extra steps and time, and is a potential turn-off for developers and casual readers that may look at an article and say "hey, this is fine.

Who would use this?
===================
Anyone reading MDN content that wants to remove a review flag.

What would users see?
=====================
Two buttons, always visible (ideally in the persistent sidebar in the redesign, but presumably at the top of the page if we implement this in the current site design), that the user can click that simply say something like "I've checked this page's accuracy" and "This article is clean" or something like that (I'm not sure how to phrase these concepts in a button).

What would users do? What would happen as a result?
===================================================
If a user reads an article and decides they've performed the reviews, they would simply click the button to clear the appropriate review flag.

This should be logged and should appear in the article's history, as well as on the Revision Dashboard.

Is there anything else we should know?
======================================
Nope.

Comment 4

[James Bennett [:ubernostrum]]

One last question: what sort of permission checks do you want on the ability to do this? I'd planned to go with a scheme where if the user can edit the document they also get the one-click "mark as reviewed" button, but if there's a different permission you want that to key off of, I need to know.

Comment 5

[Eric Shepherd [:sheppy]]

(In reply to James Bennett [:ubernostrum] from comment #4)
> One last question: what sort of permission checks do you want on the ability
> to do this? I'd planned to go with a scheme where if the user can edit the
> document they also get the one-click "mark as reviewed" button, but if
> there's a different permission you want that to key off of, I need to know.

I think that sounds good. Would be preferable to know it was done by someone that had taken the time to sign up, rather than some random yahoo. :)

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/ad9e4b8c1931d1e06b363cb5b9024c8436855c97
Fix bug 676379: Provide a 'quick-review' view for one-click technical/editorial approval.

As a side effect, fix a bug in reverting to a specific revision; the
review tags of the reverted-to revision weren't being set back properly.

https://github.com/mozilla/kuma/commit/05ea2478bf65a01512815f9123938a4590e35ba0
Merge pull request #1034 from ubernostrum/mark-as-reviewed-676379

Fix bug 676379: Provide a one-click 'quick-review' view

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/f4f0b6bb3a6caf19e1ffe82fb8f1d10ec793e117
Fix bug 676379: UI for quick review.

This adds a couple of utility functions on Revision which can tell if
it needs technical/editorial review, and then in the template for
document display adds, as needed, a block containing a form with
checkboxes for technical/editorial quick review.

https://github.com/mozilla/kuma/commit/ef95f1594034613c48fba6b8a9ee5954eaf8f96d
fix bug 676379 - clean up the quick review form