Last Comment Bug 676400 - IonMonkey: Write a MIRGraph Invariant Checker
: IonMonkey: Write a MIRGraph Invariant Checker
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Sean Stangl [:sstangl]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-03 15:28 PDT by Sean Stangl [:sstangl]
Modified: 2011-12-27 17:46 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description Sean Stangl [:sstangl] 2011-08-03 15:28:16 PDT
Work on useless control flow elimination revealed potential bugs with MIRGraph consistency -- for example, numPredecessors() seems incorrect at times.

Problems of this sort can be more readily detected, most importantly by anion, if we write an invariant checker that walks the MIRGraph and asserts on any inconsistency. We would run it after each phase of compilation when in debug mode.
Comment 1 David Anderson [:dvander] 2011-08-03 17:37:26 PDT
This is a good idea - out of curiosity, are you seeing problems even after fixing bug 676322?
Comment 2 Sean Stangl [:sstangl] 2011-12-27 17:46:53 PST
This exists in the tree as AssertGraphInvariants(), checked in with OSR (bug 700108).

Note You need to log in before you can comment on or make changes to this bug.