676430 - When editing a bug, a user not in the timetracking group generates "Use of uninitialized value in abs at Bugzilla/Bug.pm line 2682" in the web server error log

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

I cannot reproduce in 4.0.1, only in 4.1.2. If I'm not in the timetracking group, editing a bug triggers the following warning in the web server error log:

"Use of uninitialized value in abs at Bugzilla/Bug.pm line 2682". The corresponding line is in add_comment():

if ($comment eq '' && !($params->{type} || abs($params->{work_time})))

So work_time is undefined, and Perl 5.12.3 complains.

Comment 1

[Frédéric Buclin]

This is a regression due to bug 590334. In 4.0, _check_work_time() was called before abs(...) and returned 0 if work_time wasn't defined. In 4.2, abs() is called first, making it get an undefined value if the user is not in the timetracking field. Looks like a trivial abs(... || 0) will do it.

Comment 2

[Frédéric Buclin]

mkanat, what do you prefer? abs(work_time || 0), or calling validators before calling abs()?

Comment 3

[Max Kanat-Alexander]

(In reply to comment #2)
> mkanat, what do you prefer? abs(work_time || 0), or calling validators
> before calling abs()?

  Ah, just the || 0 seems like the simpler fix for now.

Comment 4

[Frédéric Buclin]

Attachment: patch, v1

Comment 5

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Bug.pm
Committed revision 7895.