676519 - Refactor the common code between nsHTMLTextAreaElement and nsHTMLInputElement into a common base class

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[(no longer active)]

There are tons of methods in these two classes which are basically copies of each other, except for the extra check in nsHTMLInputElement to make sure that we're dealing with a text input element.  These methods can probably be refactored into a common base class.

Comment 1

[Mounir Lamouri (:mounir)]

I guess we could have a nsTextControlElement class that would inherit from nsITextControlElement and actually implement it. nsHTMLInputElement and nsHTMLTextAreaElement would inherit from nsTextControlElement instead of nsITextControlElement.
Does that make sense?

Comment 2

[(no longer active)]

(In reply to Mounir Lamouri (:volkmar) from comment #1)
> I guess we could have a nsTextControlElement class that would inherit from
> nsITextControlElement and actually implement it. nsHTMLInputElement and
> nsHTMLTextAreaElement would inherit from nsTextControlElement instead of
> nsITextControlElement.
> Does that make sense?

Yeah.  We just need to decide how to handle the case of input elements which are not text controls somehow.  The current way that we do this is sucky and makes my eyes bleed every time that I read nsHTMLInputElement.cpp.  WebKit also does something like this (they have a class called HTMLTextFormControlElement).  I wish there was a better way for modeling this in C++ :(