67667 - Opening menu gives "ASSERTION: Filtered insertion point wasn't properly constructed"

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Axel Hecht]

When opening a menu that hasn't been opened before, I get a 

###!!! ASSERTION: Filtered insertion point wasn't properly constructed.
: 'Error', file /tmp/mozilla/layout/xbl/src/nsXBLBinding.cpp, line 671
###!!! Break: at file /tmp/mozilla/layout/xbl/src/nsXBLBinding.cpp, line 671

I think that menus only trigger that bug, so I CC hyatt.

Tested on cvs from Feb, 5th. Feb, 1st was ok.

Axel

Comment 1

[kinmoz]

I'm seeing this ASSERTION hit like 13 times when starting up the browser so it's 
not just opening menus.

It's really annoying on windows because we get a dialog for each assertion.

After the browser comes up, I can get the assertion to be thrown by clicking in 
a window from another app so that it gets focus, and then just moving my mouse 
over the browser window in the background.

Comment 2

[kinmoz]

I should also mention the assertions are happening after I choose my profile, 
and that I'm seeing the following WARNING printed 4 times above the 
filtered insertion point assertion in my console:

WARNING: XBL load did not complete until after document went away! Modal dialog
bug?
, file y:\mozilla\layout\xbl\src\nsXBLService.cpp, line 340

Comment 3

[Mike Pinkerton (not reading bugmail)]

--> hyatt

Comment 4

[David Hyatt]

This has been caused by Ben's checkin.  His new menu bindings are malformed.  
XBL is behaving correctly by asserting.  The menu bindings should be reverted.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Backed out my changes to the menu bindings. 

Comment 6

[Vikas Bhargava]

This is still happenning on a CVS pull from 11am EST on NT. I get two assertions 
on startup and a number on just clicking on the Bookmarks Item in the Personal 
Toolbar.

Comment 7

[Simon Fraser [no longer active]]

I see this with the modern skin. Do those bindings need fixing also?

Comment 8

[Akkana Peck]

I'm seeing this once on startup, with the modern skin.  I'm also seeing one:
###!!! ASSERTION: The prototype binding has somehow lost its XBLDocInfo! Bad bad
bad!!!
: 'info', file nsXBLPrototypeBinding.cpp, line 334

Comment 9

[Simon Fraser [no longer active]]

*** Bug 68088 has been marked as a duplicate of this bug. ***

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

sorry not a real diff, but the patch is tiny:


 RCS file: /cvsroot/mozilla/xpfe/global/resources/content/xulBindings.xml,v
 <       <children includes="menupopup,template"/>
 ---
 >       <children includes="menupopup|template"/>
 RCS file: /cvsroot/mozilla/xpfe/global/resources/content/menulistBindings.xml,v
 194c194
 <       <children includes="menupopup,template"/>
 ---
 >       <children includes="menupopup|template"/>
 204c204
 <       <children includes="menupopup,template"/>
 ---
 >       <children includes="menupopup|template"/>

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: foo

Comment 12

[Simon Fraser [no longer active]]

r=sfraser. works for me.

Comment 13

[timeless]

can we get this approved and checked in?

Comment 14

[Dan Rosen]

i'll take care of it

Comment 15

[David Hyatt]

I fixed this already.

Comment 16

[Dan Rosen]

figured.