Last Comment Bug 676708 - Remove split global stuff from the shell
: Remove split global stuff from the shell
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla8
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-04 15:33 PDT by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2011-08-11 11:32 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (13.59 KB, patch)
2011-08-04 15:53 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
no flags Details | Diff | Splinter Review
v2, with less dumb (14.29 KB, patch)
2011-08-04 16:33 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
mrbkap: review+
Details | Diff | Splinter Review

Description Jeff Walden [:Waldo] (remove +bmo to email) 2011-08-04 15:33:41 PDT
It's buggy and broken, and if the code actually were to stick around, I'd have to change it somewhat for sparse/dense API adjustments.  Plus it seems to make fuzzers cry fairly regularly, and not actually with good reason, either.
Comment 1 Jeff Walden [:Waldo] (remove +bmo to email) 2011-08-04 15:53:22 PDT
Created attachment 550868 [details] [diff] [review]
Patch

Interestingly, it seems no tests needed to be changed for this removal.  I guess people have been doing a good job at discouraging addition of split-using tests...
Comment 2 Jeff Walden [:Waldo] (remove +bmo to email) 2011-08-04 16:33:37 PDT
Created attachment 550880 [details] [diff] [review]
v2, with less dumb
Comment 3 Jeff Walden [:Waldo] (remove +bmo to email) 2011-08-08 12:21:49 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/30dd110a4ed6
Comment 4 Gary Kwong [:gkw] [:nth10sd] 2011-08-11 11:32:42 PDT
http://hg.mozilla.org/mozilla-central/rev/30dd110a4ed6

Note You need to log in before you can comment on or make changes to this bug.