Closed Bug 676708 Opened 8 years ago Closed 8 years ago

Remove split global stuff from the shell

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file, 1 obsolete file)

It's buggy and broken, and if the code actually were to stick around, I'd have to change it somewhat for sparse/dense API adjustments.  Plus it seems to make fuzzers cry fairly regularly, and not actually with good reason, either.
Attached patch Patch (obsolete) — Splinter Review
Interestingly, it seems no tests needed to be changed for this removal.  I guess people have been doing a good job at discouraging addition of split-using tests...
Attachment #550868 - Flags: review?(mrbkap)
Attachment #550868 - Attachment is obsolete: true
Attachment #550868 - Flags: review?(mrbkap)
Attachment #550880 - Flags: review?(mrbkap)
Attachment #550880 - Flags: review?(mrbkap) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/30dd110a4ed6
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
http://hg.mozilla.org/mozilla-central/rev/30dd110a4ed6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.