676723 - change unofficial android package name based on user

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Its sometimes a pain to install another developer's build because you need to uninstall your own and hence blow away your profile.

I'm proposing that we change the package name of unofficial builds from org.mozilla.fennec_unofficial to org.mozilla.fennec_blassey (in my case obviously).

Anyone see a drawback for this?

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

$USER can be an arbitrary string, but other than that, sounds OK.  I have scripts that reference the .apk but they're already using "fennec-*.apk" as I assume other folks do.  There's a small information leak by including the username in the package name, but probably nothing worse than you can find in about:buildconfig.

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 550892 [details] [diff] [review]
patch

Looks good to me.  If we do this, let's push this at the same time as the new patch in bug 669424, to minimize the number of times developers will need to wipe and reinstall their local builds.

The upside of this change is that I can install test builds from other developers without affecting my own local build.  The flip side is that I'll have to start from a fresh profile for each developer's build I test; I won't already have sync or other preferences set up.  Also, when installing multiple development builds they will all have the same name and icon.  I can live with those issues, since we don't need to ship development builds around very often.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

This also affects testing local builds too. Where before we could always assume 1 of 4 different package names, now we'll have to worry about the user who built the app.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to comment #2)
> $USER can be an arbitrary string, but other than that, sounds OK.  I have
> scripts that reference the .apk but they're already using "fennec-*.apk" as
> I assume other folks do.  There's a small information leak by including the
> username in the package name, but probably nothing worse than you can find
> in about:buildconfig.

that's a different package name. The apk file name will stay the same (fennec-8.0a1.en-US.android-arm.apk), its the java package name that changes and with it the android application id.

Comment 6

[Doug Turner (:dougt)]

much easier to upload my builds to the store!

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/385b8dfae4c0

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/385b8dfae4c0